Fix and enable goimports linter (#591)

This commit is contained in:
Duco van Amstel 2018-11-15 18:24:22 +00:00 committed by Wim
parent 4254ed3c63
commit c89085bf44
3 changed files with 7 additions and 9 deletions

View File

@ -30,7 +30,7 @@ before_script:
- PKGS=$(go list ./... | grep -v /vendor/) # All the import paths, excluding vendor/ - PKGS=$(go list ./... | grep -v /vendor/) # All the import paths, excluding vendor/
# - go get github.com/golang/lint/golint # Linter # - go get github.com/golang/lint/golint # Linter
#- go get honnef.co/go/tools/cmd/megacheck # Badass static analyzer/linter #- go get honnef.co/go/tools/cmd/megacheck # Badass static analyzer/linter
- curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.12 - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.12.2
# Anything in before_script: that returns a nonzero exit code will # Anything in before_script: that returns a nonzero exit code will
@ -40,7 +40,7 @@ script:
#- test -z "$(go fmt ./...)" # Fail if a .go file hasn't been formatted with gofmt #- test -z "$(go fmt ./...)" # Fail if a .go file hasn't been formatted with gofmt
- go test -v -race $PKGS # Run all the tests with the race detector enabled - go test -v -race $PKGS # Run all the tests with the race detector enabled
#- go vet $PKGS # go vet is the official Go static analyzer #- go vet $PKGS # go vet is the official Go static analyzer
- golangci-lint run --enable-all -D golint -D lll -D errcheck -D goimports -D gosec -D maligned -D prealloc -D gocyclo -D gochecknoglobals - golangci-lint run --enable-all -D golint -D lll -D errcheck -D gosec -D maligned -D prealloc -D gocyclo -D gochecknoglobals
#- megacheck $PKGS # "go vet on steroids" + linter #- megacheck $PKGS # "go vet on steroids" + linter
- /bin/bash ci/bintray.sh - /bin/bash ci/bintray.sh
#- golint -set_exit_status $PKGS # one last linter #- golint -set_exit_status $PKGS # one last linter

View File

@ -2,6 +2,9 @@ package bsteam
import ( import (
"fmt" "fmt"
"strconv"
"sync"
"time"
"github.com/42wim/matterbridge/bridge" "github.com/42wim/matterbridge/bridge"
"github.com/42wim/matterbridge/bridge/config" "github.com/42wim/matterbridge/bridge/config"
@ -9,10 +12,6 @@ import (
"github.com/Philipp15b/go-steam" "github.com/Philipp15b/go-steam"
"github.com/Philipp15b/go-steam/protocol/steamlang" "github.com/Philipp15b/go-steam/protocol/steamlang"
"github.com/Philipp15b/go-steam/steamid" "github.com/Philipp15b/go-steam/steamid"
//"io/ioutil"
"strconv"
"sync"
"time"
) )
type Bsteam struct { type Bsteam struct {

View File

@ -13,13 +13,12 @@ import (
"sync" "sync"
"time" "time"
prefixed "github.com/matterbridge/logrus-prefixed-formatter"
log "github.com/sirupsen/logrus"
"github.com/gorilla/websocket" "github.com/gorilla/websocket"
"github.com/hashicorp/golang-lru" "github.com/hashicorp/golang-lru"
"github.com/jpillora/backoff" "github.com/jpillora/backoff"
prefixed "github.com/matterbridge/logrus-prefixed-formatter"
"github.com/mattermost/platform/model" "github.com/mattermost/platform/model"
log "github.com/sirupsen/logrus"
) )
type Credentials struct { type Credentials struct {