GitHub/hon
3
0
Fork 0
Code Issues 33 Pull Requests 2 Packages Projects Releases 69 Wiki Activity

invalid literal for int() #16

New Issue
Closed
opened 2023-04-10 13:39:38 +02:00 by alexduf · 6 comments
alexduf commented 2023-04-10 13:39:38 +02:00 (Migrated from github.com)
Copy Link

Hi I’ve just connected a dishwasher for fun an giggles, here’s the stack trace I’m getting.

I’m guessing one of the sensors is expecting an int when the server is returning a float

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/hon/__init__.py", line 32, in async_setup_entry
    await hon.setup()
  File "/usr/local/lib/python3.10/site-packages/pyhon/api.py", line 61, in setup
    await asyncio.gather(*[
  File "/usr/local/lib/python3.10/site-packages/pyhon/device.py", line 115, in load_commands
    cmd = HonCommand(command, attr2, self._connector, self, multi=multi, program=program)
  File "/usr/local/lib/python3.10/site-packages/pyhon/commands.py", line 13, in __init__
    self._ancillary_parameters = self._create_parameters(attributes.get("ancillaryParameters", {}))
  File "/usr/local/lib/python3.10/site-packages/pyhon/commands.py", line 23, in _create_parameters
    result[parameter] = HonParameterRange(parameter, attributes)
  File "/usr/local/lib/python3.10/site-packages/pyhon/parameter.py", line 51, in __init__
    self._min = int(attributes["minimumValue"])
ValueError: invalid literal for int() with base 10: '0,5'
Hi I've just connected a dishwasher for fun an giggles, here's the stack trace I'm getting. I'm guessing one of the sensors is expecting an int when the server is returning a float ``` Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup result = await component.async_setup_entry(hass, self) File "/config/custom_components/hon/__init__.py", line 32, in async_setup_entry await hon.setup() File "/usr/local/lib/python3.10/site-packages/pyhon/api.py", line 61, in setup await asyncio.gather(*[ File "/usr/local/lib/python3.10/site-packages/pyhon/device.py", line 115, in load_commands cmd = HonCommand(command, attr2, self._connector, self, multi=multi, program=program) File "/usr/local/lib/python3.10/site-packages/pyhon/commands.py", line 13, in __init__ self._ancillary_parameters = self._create_parameters(attributes.get("ancillaryParameters", {})) File "/usr/local/lib/python3.10/site-packages/pyhon/commands.py", line 23, in _create_parameters result[parameter] = HonParameterRange(parameter, attributes) File "/usr/local/lib/python3.10/site-packages/pyhon/parameter.py", line 51, in __init__ self._min = int(attributes["minimumValue"]) ValueError: invalid literal for int() with base 10: '0,5' ```
Andre0512 commented 2023-04-10 17:10:38 +02:00 (Migrated from github.com)
Copy Link

Hi, I fixed it and cast it to a float now. I created a new beta release v0.5.0-beta.2.

Hi, I fixed it and cast it to a float now. I created a new beta release `v0.5.0-beta.2`.
Andre0512 commented 2023-04-10 18:54:07 +02:00 (Migrated from github.com)
Copy Link

Whoops I messed up, please try version v0.5.0-beta.3 🙂

Whoops I messed up, please try version `v0.5.0-beta.3` :slightly_smiling_face:
alexduf commented 2023-04-11 16:20:17 +02:00 (Migrated from github.com)
Copy Link

Hey thanks for your quick responses!

Something that worries me a little and that I noticed later was how the value is using a coma instead of a dot to separate digits. ValueError: invalid literal for int() with base 10: '0,5'

I’m in France and I’m wondering if the server is formatting that to whatever locale the user is in (we would format it 0,5 in France as opposed to 0.5 in the US). Yesterday I hacked around and got it to work by casting to floats as you did, but I also had to replace , with ., which felt very hack-ish because if it were indeed formatting to a specific locale then the parsing might be more complicated :/

Hey thanks for your quick responses! Something that worries me a little and that I noticed later was how the value is using a coma instead of a dot to separate digits. `ValueError: invalid literal for int() with base 10: '0,5'` I'm in France and I'm wondering if the server is formatting that to whatever locale the user is in (we would format it `0,5` in France as opposed to `0.5` in the US). Yesterday I hacked around and got it to work by casting to floats as you did, but I also had to replace `,` with `.`, which felt very hack-ish because if it were indeed formatting to a specific locale then the parsing might be more complicated :/
Andre0512 commented 2023-04-11 16:45:12 +02:00 (Migrated from github.com)
Copy Link

Hey, I take care of it and also used a replace. I saw this and found it also a little strange why they localize the api values. But here in Germany we also use comma as separator and I know these formatting problems well. I think this isn’t going to be a big problem when using the replace, if it’s already a dot than just nothing gets replaced. For my washing machine there is a delay parameter with values that can go above 1000 and they doesn’t use a thousand separator there, so I think this also wouldn’t be a problem.

Hey, I take care of it and also [used a replace](https://github.com/Andre0512/pyhOn/blob/main/pyhon/parameter.py#L8). I saw this and found it also a little strange why they localize the api values. But here in Germany we also use comma as separator and I know these formatting problems well. I think this isn't going to be a big problem when using the replace, if it's already a dot than just nothing gets replaced. For my washing machine there is a delay parameter with values that can go above 1000 and they doesn't use a thousand separator there, so I think this also wouldn't be a problem.
👍 1
alexduf commented 2023-04-11 16:51:38 +02:00 (Migrated from github.com)
Copy Link

Brilliant, I’ll test your patch tonight, thanks for your help!

Brilliant, I'll test your patch tonight, thanks for your help!
👍 1
alexduf commented 2023-04-12 11:39:43 +02:00 (Migrated from github.com)
Copy Link

Hey thanks, I can confirm the fix works. I’ll look into supporting DW devices though I can’t promise anything.

Hey thanks, I can confirm the fix works. I'll look into supporting DW devices though I can't promise anything.
🎉 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
air conditioner
Air conditioner (AC)
air purifier
Air purifier (AP)
air scanner
Air scanner (AS)
authentication error
Authentication Error
bug
Something isn't working
candy
Candy
dish washer
Dish washer (DW)
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
fridge
Fridge (REF)
good first issue
Good for newcomers
haier
Haier
help wanted
Extra attention is needed
hob
Hob (IH)
hood
Hood (HO)
hoover
Hoover
invalid
This doesn't seem right
microwave
Microwave (MW)
new appliance
New Appliance Request
oven
Oven (OV)
pyhOn
Issue in pyhOn
question
Further information is requested
robot vacuum cleaner
Robot vacuum cleaner (RVC)
tumble dryer
Tumble dryer (TD)
washer dryer
Washer dryer (WD)
washing machine
Washing machine (WM)
water heater
Water Heater (WH)
wine cellar
Wine Cellar (WC)
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Georg Mikaela pratyush
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GitHub/hon#16
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?