Added WD device type sensors. #13

2023-04-05T23:14:42+02:00

alexandre-leites commented

2023-04-05 23:14:42 +02:00

(Migrated from github.com)

Hey,

After some testing I finished with the following useful sensors for my device type. In the beginning I was just copying the WM interface but there is notable difference, therefore I did not just do a copy of the dictionary.

In the future we may need to implement a “base” device and inherit from it, but I think we should way for more device contributions to know which sensors and switches are really global.

Let me know if you still think we need more changes.

Hey, After some testing I finished with the following useful sensors for my device type. In the beginning I was just copying the WM interface but there is notable difference, therefore I did not just do a copy of the dictionary. In the future we may need to implement a "base" device and inherit from it, but I think we should way for more device contributions to know which sensors and switches are really global. Let me know if you still think we need more changes.

Andre0512 (Migrated from github.com) approved these changes 2023-04-07 20:56:32 +02:00

Andre0512 (Migrated from github.com) left a comment

Looks good 👍

Looks good :+1:

Sign in to join this conversation.

No reviewers

Andre0512

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: GitHub/hon#13