Shivaram Lingamneni
40bd298a91
fix the reopened #1844
2022-01-02 01:07:37 -05:00
Shivaram Lingamneni
ed75533cb1
optionally protect against multiple starts with flock ( #1873 )
...
* optionally protect against multiple starts with flock
Fixes #1823
* use traditional .lock extension
* move config key to top level
2022-01-01 18:56:40 -05:00
Shivaram Lingamneni
a57bf46e6a
small refactor
2021-12-30 12:59:14 -05:00
William Rehwinkel
b929691470
Fix #1883 Nickserv gives error when user attempt to change password to *
2021-12-30 12:15:30 -05:00
Shivaram Lingamneni
24ad24562e
update help entry for CHATHISTORY
2021-12-29 12:45:29 -05:00
Shivaram Lingamneni
e15c355f18
fix #1876
...
INVITE did not exempt from +b unless the channel was coincidentally also +i.
This was a regression introduced in v2.4.0.
2021-12-19 18:30:18 -05:00
Shivaram Lingamneni
76f7748c8a
correctly account for nickname in CAP LS arithmetic
...
The arithmetic was assuming that the nickname is * (which it is
pre-registration). However, we were sending the actual nickname
post-registration. It would be simpler to always send *, but it
appears that the nickname is actually required by the spec:
>Replies from the server must [sic] contain the client identifier name or
>asterisk if one is not yet available.
2021-12-16 01:59:36 -05:00
Shivaram Lingamneni
ec4fb90d2b
+I should allow unregistered users to join a +R channel
...
See #1858 : this was the intent all along, but I missed this issue.
2021-12-15 22:52:11 -05:00
Shivaram Lingamneni
98e87f6cc0
explicitly close the DB during importdb
...
There is no change in behavior since committing the transaction
already write(2)'s all the data to disk. But let's comply with
the official buntdb API.
2021-12-12 22:27:05 -05:00
Shivaram Lingamneni
9293858ba1
bump database version generated by importer
...
This should have been done in 8b2f6de3e0
, since we updated both
the database schema and the importer then.
2021-12-12 22:09:42 -05:00
Shivaram Lingamneni
f3f805acb8
send *
for WHOX o (oplevel) instead of 0
...
Jobe points out that 0 is a valid oplevel in some contexts,
* is a better placeholder for "unimplemented".
2021-12-12 03:05:56 -05:00
Shivaram Lingamneni
0d0d9e72b4
Merge pull request #1861 from slingamn/issue1860_amode
...
fix #1860
2021-12-09 04:18:14 -05:00
Shivaram Lingamneni
ac17bf0e9d
Merge pull request #1857 from slingamn/dollarsign
...
disallow initial $ in nicknames
2021-12-09 04:17:57 -05:00
Shivaram Lingamneni
9d9ee11224
fix #1860
...
CS AMODE changes should take immediate effect even if the nick
does not match the account.
2021-12-08 23:47:33 -05:00
Shivaram Lingamneni
8be8f0f08d
fix #1858
...
The channel mode +R used to both prevent joins by unregistered users,
and prevent unregistered users who happened to be joined from speaking.
This changes the behavior so that +R only prevents joins:
1. This allows users who were invited or SAJOIN'ed to speak
2. To restore the old semantics, chanops can set +RM
2021-12-07 01:31:07 -05:00
Shivaram Lingamneni
f40d868cf5
disallow initial $ in nicknames
...
It collides with the massmessage mask syntax. Reported by @emersion
2021-12-06 14:17:45 -05:00
Shivaram Lingamneni
cb757c703d
change FAIL AUTHENTICATE VERIFICATION_REQUIRED to be a NOTE
...
See discussion on #1852
2021-12-01 12:16:03 -05:00
Shivaram Lingamneni
72959eb1cf
Merge pull request #1852 from slingamn/fail_authenticate
...
add FAIL AUTHENTICATE VERIFICATION_REQUIRED
2021-11-30 20:35:33 -05:00
Shivaram Lingamneni
7d66368274
add FAIL AUTHENTICATE VERIFICATION_REQUIRED
...
From discussion with @emersion, this will help with UX if people try to
log into their unverified accounts.
2021-11-30 15:27:25 -05:00
Shivaram Lingamneni
645721f97e
fix missing parenthesis in UBAN INFO
2021-11-30 03:40:03 -05:00
Shivaram Lingamneni
fd45529d94
fix #1842
...
Warn about banning a single IPv6 address
2021-11-30 03:27:40 -05:00
Shivaram Lingamneni
eef9753912
reorder imports
2021-11-30 03:18:01 -05:00
Shivaram Lingamneni
9ff4047fa6
fix #1840
...
Account registrations pending verification should produce a logline and
send a sno.
2021-11-30 03:18:01 -05:00
Shivaram Lingamneni
ee720f60e2
fix #1826
...
CS PURGE should send a snomask
2021-11-30 03:18:01 -05:00
Shivaram Lingamneni
c51569420a
fix #1844
...
Send snomasks for HS SET
2021-11-30 03:18:01 -05:00
e0f4fcee61
NS SUSPEND now req 'ban' capabs
2021-11-18 17:11:32 +05:30
Shivaram Lingamneni
ac91beabfd
Merge pull request #1835 from slingamn/who.1
...
fix two WHO bugs
2021-11-16 21:45:40 -05:00
Shivaram Lingamneni
bc5c2a1250
fix casefolding issue in muting RELAYMSG
...
Reported by @mogad0n; the mute mask was being case-canonicalized,
but the RELAYMSG identifier wasn't being case-canonicalized before
the check.
2021-11-16 18:39:38 -05:00
Shivaram Lingamneni
2038763e10
fix #1730
...
`WHO #channel o` is supposed to return only server operators.
This is RFC1459 cruft; just return an empty list in this case.
2021-11-14 15:13:56 -05:00
Shivaram Lingamneni
62b2d0341e
fix #1831
...
RPL_ENDOFWHO should send the original, un-normalized mask
2021-11-14 13:41:27 -05:00
Shivaram Lingamneni
92f6bf2d03
set up new development version
2021-11-14 13:12:58 -05:00
Shivaram Lingamneni
c70e518eed
bump version to v2.8.0
2021-11-14 00:11:19 -05:00
Shivaram Lingamneni
050e27b31b
fix #1798
...
Improve documentation for use of certificate fingerprints
2021-11-13 19:58:56 -05:00
Shivaram Lingamneni
3d4170ef98
Merge pull request #1825 from slingamn/samode_f
...
SAMODE +f shouldn't require channel privileges
2021-11-11 12:32:17 -05:00
Shivaram Lingamneni
4bffdba610
SAMODE +f shouldn't require channel privileges
...
Reported by @Mikaela ; normally this requires +o or higher on the
channel that is the target of the forward, but SAMODE should bypass
this check.
2021-11-09 13:23:25 -05:00
Shivaram Lingamneni
4a3ac617a5
Merge pull request #1819 from slingamn/password_message
...
fix error message for NS SET EMAIL without the password
2021-11-08 03:20:45 -05:00
Shivaram Lingamneni
dc75b24d23
clarify comment on CAP byte arithmetic
2021-11-07 13:32:18 -05:00
Shivaram Lingamneni
9f0c3cdc0e
fix error message for NS SET EMAIL without the password
2021-11-04 20:10:56 -04:00
Shivaram Lingamneni
ea4b93dd59
bump version to v2.8.0-rc1
2021-11-03 05:33:46 -04:00
Shivaram Lingamneni
7e93770540
Merge pull request #1813 from slingamn/message_error
...
CHATHISTORY with nonexistent msgid should send empty batch
2021-11-02 20:59:02 -04:00
Shivaram Lingamneni
ad8c97c9bb
CHATHISTORY with nonexistent msgid should send empty batch
...
It was sending MESSAGE_ERROR, which was inappropriate. Send an empty batch
for now (this is at parity with the in-memory implementation).
2021-11-02 18:50:41 -04:00
Shivaram Lingamneni
c4e376c8bb
fix spurious error logline in schema change
2021-11-02 18:26:51 -04:00
Shivaram Lingamneni
85fabaad6d
fix case where CS TRANSFER as an operator required acceptance
...
Reported by @mogad0n. If a user had both operator privileges and
channel owner privileges, the CS TRANSFER would proceed as though
unprivileged, requiring acceptance by the receiving user. Fix this
to not require acceptance.
2021-11-02 18:26:47 -04:00
Shivaram Lingamneni
c9b54ee2b8
Merge pull request #1809 from slingamn/issue1676_again.3
...
fix #1676 , take 2
2021-11-02 03:51:04 -04:00
Shivaram Lingamneni
ea1678ec8f
Merge pull request #1810 from slingamn/nolusers
...
fix #1802
2021-11-01 23:25:32 -04:00
Shivaram Lingamneni
61bce74018
fix spurious "corrupt account creds" logline
...
Reported by @tacerus. This was most likely introduced by 8b2f6de3e
.
2021-11-01 18:48:37 -04:00
Shivaram Lingamneni
51d573d3c9
fix #1802
...
Add a config option to suppress LUSERS
2021-11-01 04:48:31 -04:00
Shivaram Lingamneni
8c556fe8c5
schema change to remove ReplayJoinsNever
...
See #1676
2021-11-01 04:36:06 -04:00
Shivaram Lingamneni
4749d7e776
fix #1676 , take 2
...
Ensure the pagination window is full by making sure that every history item
gets a replay line in CHATHISTORY output, even TAGMSG.
2021-11-01 04:34:59 -04:00
Shivaram Lingamneni
3ec5ffa340
Revert "fix #1676 "
...
This reverts commit 5bbee02fe6
.
2021-11-01 04:34:59 -04:00