Commit Graph

1612 Commits

Author SHA1 Message Date
Alex Jaspersen df9bf15f00 Add support for setting user modes by default. 2020-04-30 03:54:09 +00:00
Shivaram Lingamneni a06b4d5e88
Merge pull request #965 from slingamn/delayedlist.1
fix #964
2020-04-26 22:05:46 -07:00
Shivaram Lingamneni 3626958f1e also exempt operators from LIST restrictions 2020-04-27 00:58:48 -04:00
Shivaram Lingamneni 5cdb81e1ea use Nick() 2020-04-26 03:08:44 -04:00
Shivaram Lingamneni 57e2187742 fix #964 2020-04-26 02:52:09 -04:00
Shivaram Lingamneni a7f020320e make erase confirmation code nondeterministic 2020-04-24 15:41:58 -04:00
Shivaram Lingamneni f87b71b93f fix #962 2020-04-24 15:39:39 -04:00
Shivaram Lingamneni 4722f8a96c fix #959 2020-04-24 01:33:21 -04:00
Shivaram Lingamneni 40d3c59139 fix #955 2020-04-23 02:02:07 -04:00
Shivaram Lingamneni eebe681538 fix #532 2020-04-23 01:29:08 -04:00
Shivaram Lingamneni bd088ea197 fix #951 2020-04-22 22:19:59 -04:00
Shivaram Lingamneni 360a5af90d fix #950 2020-04-22 21:52:24 -04:00
Hubert Hirtz f2e3287f8d use servername instead of nickmask for RPL_UMODEIS prefix 2020-04-16 09:31:54 +02:00
Shivaram Lingamneni f07a456688
Merge pull request #944 from slingamn/issue827_rename
fix #827
2020-04-13 10:13:47 -07:00
Shivaram Lingamneni 9a6cb84b58 fix #943 2020-04-13 11:54:39 -04:00
Shivaram Lingamneni 04549e7919 fix #827 2020-04-12 22:41:23 -04:00
Shivaram Lingamneni f4f7a8afaa shorten type names to 10 chars 2020-04-12 14:01:07 -04:00
Shivaram Lingamneni 11d1d96d71 align up to 10 2020-04-12 13:45:24 -04:00
Shivaram Lingamneni dbbcd800c9 align log messages with space padding 2020-04-12 13:33:36 -04:00
Shivaram Lingamneni 6e4b0b3125 remove log type sanitization 2020-04-12 13:33:36 -04:00
Shivaram Lingamneni ded03ee618 fix timestamp formatting 2020-04-12 13:30:43 -04:00
Shivaram Lingamneni 6a900ca0cb strip out log coloring 2020-04-12 12:54:02 -04:00
Shivaram Lingamneni 80424a6f00 fix #936 2020-04-07 12:24:44 -04:00
Shivaram Lingamneni 3f717436f8 fix #933 2020-04-06 13:10:38 -04:00
Shivaram Lingamneni ecb4aa03aa
Merge pull request #931 from slingamn/issue930
fix #930
2020-04-06 07:52:04 -07:00
Shivaram Lingamneni ae2a92ca9a
Merge pull request #929 from slingamn/verify_rename.1
enforce nick protection immediately after verification
2020-04-06 07:51:53 -07:00
Shivaram Lingamneni 8fb5eee171 fix #930 2020-04-06 10:47:55 -04:00
Shivaram Lingamneni d6e3f188cf enforce nick protection immediately after verification 2020-04-06 02:38:29 -04:00
Shivaram Lingamneni ee05a4324d fix #920, #921 2020-04-05 03:48:59 -04:00
Shivaram Lingamneni 6e630a0b5c add the smtp code from the go 1.14.1 release 2020-04-03 11:32:13 -04:00
Shivaram Lingamneni 46f68d4cf2 fix #922 2020-03-31 14:28:26 -04:00
Shivaram Lingamneni bbd8807d65
Merge pull request #915 from slingamn/issue817_fakelag.1
fix #817
2020-03-29 18:00:34 -07:00
Shivaram Lingamneni 895a0e6d68 fix #913 2020-03-27 17:52:37 -04:00
Shivaram Lingamneni 73d795e6b4 fix #817 2020-03-27 10:40:19 -04:00
Shivaram Lingamneni 8acd58e263 fix #908 2020-03-26 16:25:37 -04:00
Shivaram Lingamneni 0cce086367
Merge pull request #910 from slingamn/amode.2
partial implementation of #729
2020-03-26 09:30:30 -07:00
Shivaram Lingamneni b61d258d0c retain nickname protections after unregistration 2020-03-25 16:24:08 -04:00
Shivaram Lingamneni c238f07543 fix #908 2020-03-25 14:07:43 -04:00
Shivaram Lingamneni f5fe580d22 partial implementation of #729
This propagates CS AMODE changes to the actual modes, but not the other
way around.

Also fixes #909.
2020-03-25 12:13:31 -04:00
Hubert Hirtz 1095aca5e7 irc/modes: remove duplicate test case 2020-03-24 14:56:50 +01:00
Shivaram Lingamneni f2da69d49f fix #898 2020-03-22 18:18:48 -04:00
Shivaram Lingamneni 761d215ecd remove unnecessary comment 2020-03-22 10:09:20 -04:00
Shivaram Lingamneni f3d64d2859 move idletimer and fakelag initialization before certfp read 2020-03-22 10:09:20 -04:00
Shivaram Lingamneni 101dc6b0d9 increase TLS handshake timeout 2020-03-22 10:09:20 -04:00
Shivaram Lingamneni 48f6bb79c8
Merge pull request #890 from slingamn/permanent_accounts.2
make account names permanent identifiers
2020-03-21 21:20:18 -07:00
Shivaram Lingamneni 5e5003f5b6 fix #850 2020-03-20 15:14:27 -04:00
Shivaram Lingamneni 811da03ab5 fix #889 2020-03-20 14:47:40 -04:00
Shivaram Lingamneni 3363076689 fix #793 2020-03-20 14:29:49 -04:00
Shivaram Lingamneni 2d908eac8b fix #874 2020-03-20 09:16:22 -04:00
Shivaram Lingamneni 28b7639c26 fix #883 2020-03-20 07:17:58 -04:00
Shivaram Lingamneni 2428acab95 enhancements to roleplay 2020-03-19 17:10:28 -04:00
Shivaram Lingamneni 2bb36e6cb8 fix roleplay messages not being relayed
See #865.
2020-03-19 15:12:28 -04:00
Shivaram Lingamneni 621df31577 fix #704 2020-03-19 07:26:17 -04:00
Shivaram Lingamneni b32dd5ce33 rename a variable 2020-03-19 05:09:25 -04:00
Shivaram Lingamneni ca3be51028 fix double application of guest prefix 2020-03-19 05:08:53 -04:00
Shivaram Lingamneni bd45c346dc fix #685 2020-03-18 07:07:20 -04:00
Shivaram Lingamneni 9559ea6764 fix #408 2020-03-18 07:07:20 -04:00
Shivaram Lingamneni 442055ff30 fix #842 2020-03-18 07:07:20 -04:00
Shivaram Lingamneni ece444d04b fix #805 2020-03-18 07:07:20 -04:00
Shivaram Lingamneni 65ebe7f64a fix #868 2020-03-18 07:07:20 -04:00
Shivaram Lingamneni 39d3194104 fix #869 2020-03-18 07:07:20 -04:00
Shivaram Lingamneni 988d97d68a fix #846 2020-03-18 07:07:20 -04:00
Shivaram Lingamneni d98e3581b3 disallow /SAMODE nick +o 2020-03-17 13:19:27 -04:00
Shivaram Lingamneni 76d3ecca71 fix #866 2020-03-17 13:00:53 -04:00
Shivaram Lingamneni 6d65335071 fix various bugs 2020-03-17 09:07:32 -04:00
Shivaram Lingamneni edd161ddfd rename config keys from review feedback 2020-03-17 09:04:14 -04:00
Shivaram Lingamneni 26fd3e69a8 fix #749 2020-03-16 13:48:14 -04:00
Shivaram Lingamneni 458d813ee1 work around mirc bug 2020-03-11 18:57:42 -04:00
Shivaram Lingamneni bbe9e09d46 clean up trailing hack 2020-03-11 18:57:25 -04:00
Shivaram Lingamneni 2f243ab65b bump to next development version 2020-03-08 23:01:52 -04:00
Shivaram Lingamneni 8fd326fd33 bump version to 2.0.0 2020-03-08 05:36:11 -04:00
Shivaram Lingamneni d50c4c2bd6 fix #848 2020-03-06 04:47:47 -05:00
Shivaram Lingamneni 5447fc79ff fix confusion between lastSeen and lastActive 2020-03-02 03:06:57 -05:00
Shivaram Lingamneni d72037725b simplify read of lastSeen 2020-03-02 02:52:51 -05:00
Shivaram Lingamneni e7c1800893 fix a spurious error logline
unregistering an always-on client would produce
"attempting to persist logged-out client : x"
because the client was always-on, but also being ejected
2020-03-02 01:54:40 -05:00
Shivaram Lingamneni d5f68215e1 mark dirty when a client first becomes always-on 2020-03-02 01:53:02 -05:00
Shivaram Lingamneni 3005e95c1f rename IncludeAllChannelAttrs 2020-03-02 01:46:22 -05:00
Shivaram Lingamneni c0192e0e52 add missing initialization for writerSemaphore
It was only initialized for always-on clients, not for regular clients.
This explains a lot in terms of #812 failing to reproduce.
2020-03-02 01:32:08 -05:00
Shivaram Lingamneni a74450d6ca remove redundant database write on always-on recreation 2020-03-02 01:24:08 -05:00
Shivaram Lingamneni b4f720ae04 bump version to 2.0.0-rc1 2020-03-02 00:03:03 -05:00
Shivaram Lingamneni 8ed6634b3f
Merge pull request #823 from slingamn/changelog.2
branding, manual, and changelog updates for 2.0
2020-03-01 20:59:16 -08:00
Shivaram Lingamneni 579ef668ac fix #838 2020-03-01 23:13:21 -05:00
Shivaram Lingamneni 3e01e9995b fix #836 2020-03-01 03:39:25 -05:00
Shivaram Lingamneni d967129446 fix #833 2020-02-28 05:41:08 -05:00
Shivaram Lingamneni 85dfebce43 fix #831 2020-02-27 19:29:14 -05:00
Shivaram Lingamneni 1dc93bbb9f fix #829
also, handle nickname targets in znc.in/playback
2020-02-27 14:43:59 -05:00
Shivaram Lingamneni db39608bcb change "last signoff" tracking to "last seen"
Explicit quit and ping timeout behave the same way,
but reattach after abandoning/losing the previous session
(without the break being detected server-side) is more aggressive
about replaying missed messages, at the cost of potential duplication.
2020-02-27 02:17:58 -05:00
Shivaram Lingamneni 3a78029809 partial fix for #812 2020-02-26 03:19:14 -05:00
Shivaram Lingamneni e78cb70d33 streamline credits 2020-02-26 02:39:37 -05:00
Shivaram Lingamneni 42ccd81205 make an exception for saset 2020-02-26 02:00:38 -05:00
Shivaram Lingamneni 521617559f fix #821
Or try to, anyway
2020-02-26 01:44:05 -05:00
Shivaram Lingamneni 1975b0968a fix double decrement of stats on ping timeout 2020-02-25 14:04:50 -05:00
Shivaram Lingamneni ce208cb3e1 fix #814 2020-02-25 13:26:49 -05:00
Shivaram Lingamneni 3e787de994 handle kiwi's BEFORE * 2020-02-25 00:19:24 -05:00
Shivaram Lingamneni b45f8436a4 refactoring / bug fixing in history preferences 2020-02-25 00:19:24 -05:00
Shivaram Lingamneni 891da73e56 fix handling of history grace periods 2020-02-24 05:44:55 -05:00
Shivaram Lingamneni 44b79a052c raise passphrase length limit to 300 bytes
For irctest compatibility.

Fixes #775
2020-02-23 00:12:21 -05:00
Shivaram Lingamneni fb8b73e29a Merge branch 'persistent.14' 2020-02-22 23:10:52 -05:00
Shivaram Lingamneni c445b45f31
Merge pull request #800 from slingamn/issue791_crashserver
fix #791
2020-02-22 20:08:42 -08:00
Shivaram Lingamneni fec27cc7c2
Merge pull request #799 from slingamn/issue725_deoper.1
fix #725
2020-02-22 20:07:29 -08:00
Shivaram Lingamneni e1e3062dad
Merge pull request #797 from slingamn/issue775_passlength
fix #775
2020-02-22 20:07:14 -08:00
Shivaram Lingamneni 010bb3e926
Merge pull request #796 from slingamn/issue715_upgradedb
fix #715
2020-02-22 20:07:03 -08:00
Shivaram Lingamneni 85a536977c factor out confirmation codes into utils, change their format 2020-02-22 22:34:39 -05:00
Shivaram Lingamneni 93708c23eb update draft/chathistory spec link in /help 2020-02-21 13:10:08 -05:00
Shivaram Lingamneni 490b3722bd add a logline and a help description for CRASHSERVER 2020-02-21 13:07:22 -05:00
Shivaram Lingamneni 41813cc15a fix #791 2020-02-21 12:41:04 -05:00
Shivaram Lingamneni 904fa9653c clear reg date and settings during logout 2020-02-21 06:36:32 -05:00
Shivaram Lingamneni 438fffab99 fix #725 2020-02-21 06:10:35 -05:00
Shivaram Lingamneni 91bb7f5877 fix #775 2020-02-21 04:26:17 -05:00
Shivaram Lingamneni 829481ab40 fix #715 2020-02-21 04:24:18 -05:00
Shivaram Lingamneni 5fe4d0b133 fix #794
Remove support for `listen` config block
2020-02-21 04:12:00 -05:00
Shivaram Lingamneni fd90893fa6 handle old bouncer name for multiclient config 2020-02-21 00:33:55 -05:00
Shivaram Lingamneni f5ca35ed72 rename 'bouncer' to 'multiclient' 2020-02-21 00:33:55 -05:00
Shivaram Lingamneni 03378da81b CHATHISTORY with no results SHOULD send an empty batch 2020-02-21 00:33:48 -05:00
Shivaram Lingamneni 98a7b45d96 add mysql timeouts 2020-02-21 00:33:48 -05:00
Shivaram Lingamneni 8123e3c08f improve nick and channel length validation 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 108ef3f424 don't double-store messages users send to themselves 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni fab0630180 time.Unix still requires normalization to UTC 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 8031085c26 clean up nil checks relevant to always-on join 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 282e7a4d57 don't write to mysql while holding joinPartMutex 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 4472683d58 persist lastSignoff in the database 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 17a89838b8 fix Client.historyStatus 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 8f4c14c783 miscellaneous review fixes 2020-02-21 00:33:37 -05:00
Shivaram Lingamneni 82732d5b5d fix behavior of echo-message without message-tags 2020-02-20 01:51:19 -05:00
Shivaram Lingamneni 5892680f60 consolidate sending DMs to targets with sending copies to non-originating sessions 2020-02-20 01:51:19 -05:00
Shivaram Lingamneni ef161c47ed use custime.Duration for more config fields 2020-02-20 00:09:39 -05:00
Shivaram Lingamneni 7b3caed20f fix/enhancement to custime 2020-02-19 02:45:50 -05:00
Shivaram Lingamneni e59aa43225 fix StringToBool (thanks @wrmsr) 2020-02-19 00:54:42 -05:00
Shivaram Lingamneni ad32356e34 move authentication data from Client to Session 2020-02-19 00:24:21 -05:00
Shivaram Lingamneni 33dac4c0ba initial persistent history implementation 2020-02-19 00:24:12 -05:00
Shivaram Lingamneni 306ca986a8 minor fixes 2020-02-11 22:08:41 -05:00
Shivaram Lingamneni 0c2d8adeac improve maintainability and license compliance
0. Maximum parity with upstream code
1. Added Apache-required modification notices
2. Added Apache license
2020-02-11 16:13:12 -05:00
Shivaram Lingamneni c13597f807 additional LDAP support 2020-02-11 06:35:17 -05:00
Matt Ouille 5ba2527eb0 Fix compilation errors 2020-02-09 22:13:12 -05:00
Matt Ouille d4afb027e5 Add LDAP support 2020-02-09 22:13:02 -05:00
Shivaram Lingamneni b964a201c1 fix #776 2020-02-07 13:28:49 -05:00
Shivaram Lingamneni a3f008e348 mitigate #772 2020-02-06 17:56:10 -05:00
Shivaram Lingamneni 88d7e98011 add vhost snomasks 2020-02-02 02:03:08 -05:00
Shivaram Lingamneni 5426c9fdc0 disallow TAKE and REQUEST while under a FORBID 2020-02-01 23:51:29 -05:00
Shivaram Lingamneni e1f56aaee3 fix #764 2020-02-01 22:19:33 -05:00
Shivaram Lingamneni 52d85517cd actually fix #760 2020-01-29 16:27:59 -05:00
Shivaram Lingamneni fd46874ad3 fix #760 2020-01-29 15:45:50 -05:00
Shivaram Lingamneni b329cf430e
Merge pull request #744 from slingamn/hostserv_offer.1
add support for offering vhosts
2020-01-28 19:36:17 -08:00
Shivaram Lingamneni 955cdbdfef impose throttle checks on HS TAKE 2020-01-28 22:27:56 -05:00
Shivaram Lingamneni dedf78d0e9 review fixes 2020-01-28 21:23:31 -05:00
Shivaram Lingamneni 7d3c0f7884 fix #757 2020-01-27 21:10:24 -05:00
Shivaram Lingamneni 166dc60729 fix #753
Also add +C no-ctcp mode, since it's not conflicted
2020-01-26 21:07:20 -05:00
Shivaram Lingamneni 1fc9a04503 fix #754 2020-01-25 21:06:55 -05:00
Shivaram Lingamneni 6e2b2a44b8 set the time of a multiline message at BATCH - 2020-01-20 00:37:13 -05:00
Shivaram Lingamneni 5d662742b9 remove oragono.io/maxline-2 and fmsgid 2020-01-18 23:47:05 -05:00
Shivaram Lingamneni 0cebdba82c
Merge pull request #750 from slingamn/isupport_fix
fix incorrect values of UTF8MAPPING for non-PRECIS casefoldings
2020-01-14 13:11:53 -05:00
Shivaram Lingamneni d807f1252f move generateISupport to config.go 2020-01-14 01:21:47 -05:00
Shivaram Lingamneni 3ff586e821 don't read globalCasemappingSetting in generateISupport
The isupport is always a pure function of the Config object,
not of Server or any globals.
2020-01-14 01:19:48 -05:00
Shivaram Lingamneni 90b428b416 fix #745 2020-01-12 11:24:11 -05:00
Shivaram Lingamneni 2db14c91b9 review fixes 2020-01-11 22:52:30 -05:00
Shivaram Lingamneni 05cb80507f fix #741 2020-01-11 22:43:40 -05:00
Shivaram Lingamneni 11ca86028c fix #741 2020-01-09 13:49:36 -05:00
Shivaram Lingamneni 6838d19acc don't check the real IP for bans on proxy-before-TLS
In the k8s PROXY-before-TLS setting, we don't know all the IPs
of the load balancers, so we can't whitelist them, so they're at
risk of being d-lined.
2020-01-09 04:38:59 -05:00
Shivaram Lingamneni 2110f3dad7 fix #705 2020-01-08 02:20:37 -05:00
Shivaram Lingamneni eb630b7657 Revert "never set the certfp lookup key before verification"
This reverts commit a120cc2443.
2020-01-06 15:00:26 -05:00
Shivaram Lingamneni a120cc2443 never set the certfp lookup key before verification 2020-01-06 12:53:21 -05:00
Shivaram Lingamneni 1b35c6887f fix #733 2020-01-06 12:21:52 -05:00
Shivaram Lingamneni 1ae38091a3
Merge pull request #728 from slingamn/issue727_group_ghost.1
fix #727
2020-01-05 03:26:26 -05:00
Shivaram Lingamneni d67d77bee7 fix #731 2020-01-03 09:46:55 -05:00
Shivaram Lingamneni bc0712b19b fix #727 2019-12-31 21:19:28 -05:00
Shivaram Lingamneni bd822853bc fix some translation warnings 2019-12-30 14:47:22 -05:00
Shivaram Lingamneni f920d3b79f fix #530, #721 2019-12-29 12:05:01 -05:00
Shivaram Lingamneni 9de9fcf069
Merge pull request #695 from slingamn/issue693_casemappings.4
#693: configurable casemappings
2019-12-29 09:20:06 -05:00
Shivaram Lingamneni f6757f814e
Merge pull request #707 from slingamn/multiline.4
implement draft/multiline
2019-12-26 23:18:54 -05:00
Shivaram Lingamneni 47ac8e984f remove unnecessary helper 2019-12-26 22:54:00 -05:00
Shivaram Lingamneni 68e3b74b79
Merge pull request #717 from slingamn/issue716
fix #716
2019-12-25 21:11:53 -05:00
Shivaram Lingamneni 8c1db7a2f5 better UX for cancelling channel transfers 2019-12-25 15:59:38 -05:00
Shivaram Lingamneni 33c8b2177e fix a bug
In the previous commit, the client would receive a failure message but would
actually remain logged in after an authzid/authcid mismatch. This was a
correctness rather than a security issue, but now it's fixed so that the client
never logs in in the first place.
2019-12-25 15:06:26 -05:00
Shivaram Lingamneni c8ccf94936 fix #716 2019-12-25 12:44:55 -05:00
Shivaram Lingamneni 9b5d6bf746 fix #713 2019-12-24 16:20:18 -05:00
Shivaram Lingamneni 1487980fe0 Fix #710 2019-12-24 15:03:37 -05:00
Shivaram Lingamneni cd3ff3922e fill in more authzid/authcid details 2019-12-24 12:46:31 -05:00
Pavel Djundik 6831b0ffdc
Fix `authcid` variable name 2019-12-24 19:33:33 +02:00
Shivaram Lingamneni 358c4b7d81 implement draft/multiline 2019-12-24 09:29:54 -05:00
Shivaram Lingamneni 7a6925fa3f Merge remote-tracking branch 'origin/master' into issue702 2019-12-23 11:32:15 -05:00
Shivaram Lingamneni bf5a02f077
Merge pull request #692 from slingamn/issue683_channelpurge.1
chanserv enhancements and miscellaneous fixes
2019-12-22 10:41:24 -05:00
Shivaram Lingamneni 4391b1ba5a restrict ASCII mode to printable characters only 2019-12-22 09:57:49 -05:00
Shivaram Lingamneni 781bb6b051 more systematic bad-character check in permissive mode 2019-12-22 09:31:51 -05:00
Shivaram Lingamneni 2d4dbeba1c disallow some bad characters in foldPermissive 2019-12-22 09:19:28 -05:00
Shivaram Lingamneni 76a8768d05 make rehash-enable logic a little more uniform 2019-12-22 08:42:56 -05:00
Shivaram Lingamneni bd6c2117e8 fix analogous issue for history
History couldn't be enabled by rehash if autoresize-window was nonzero.
2019-12-22 08:11:24 -05:00
Shivaram Lingamneni 26ca016c66 fix the analogous issue for vhosts 2019-12-21 20:26:40 -05:00
Shivaram Lingamneni 25c4eb2996 fix #702 2019-12-21 20:19:19 -05:00
Shivaram Lingamneni 0df25e0e30 remove redundant error check 2019-12-19 18:41:46 -05:00
Shivaram Lingamneni c4e66d8b83
Merge pull request #698 from slingamn/issue616_prefs.2
fix #616
2019-12-19 18:38:18 -05:00
Shivaram Lingamneni 9bc5fb78cf
Merge pull request #700 from slingamn/issue347_snomasks
fix #347
2019-12-19 18:35:19 -05:00
Shivaram Lingamneni 01488bfe2e slightly more defensive implementation of /OPER check 2019-12-19 18:30:19 -05:00
Shivaram Lingamneni 78da024b24 improve an error message 2019-12-19 09:30:49 -05:00
Shivaram Lingamneni 0c33c3399f fix #347 2019-12-19 09:27:54 -05:00
Shivaram Lingamneni b717402b5e implement review feedback
1. If both fingerprint and hash are specified, require both instead of either
2. Implement auto-oper on connect
2019-12-19 06:33:43 -05:00
Shivaram Lingamneni 6033d9f569 tweaks for consistency 2019-12-18 20:33:58 -05:00
Shivaram Lingamneni 6740222ecb fix #616 2019-12-18 17:38:14 -05:00
Shivaram Lingamneni e143aaa83f fix #696 2019-12-18 16:04:43 -05:00
Shivaram Lingamneni f9b5224ae0 have realSkeleton use cases.Fold as well 2019-12-18 12:26:09 -05:00
Shivaram Lingamneni 91d6888b7e fix #693 2019-12-18 12:26:09 -05:00