Commit Graph

1744 Commits

Author SHA1 Message Date
Shivaram Lingamneni 4c0144c708 bump version to 2.3.0-rc1 2020-08-23 00:20:20 -04:00
Shivaram Lingamneni 1dd0c432fd use utils.StringSet in more places 2020-08-22 22:43:21 -04:00
Shivaram Lingamneni b1c3a1467a clean up handling of no-op nick changes 2020-08-22 22:26:50 -04:00
Shivaram Lingamneni e706124852 correct trailing space on +R usermode documentation 2020-08-13 13:17:31 -04:00
Shivaram Lingamneni 682f8f66c5 add compiler version to INFO output 2020-08-10 18:14:22 -04:00
Shivaram Lingamneni c50c267d3c better debug logline for failed message building 2020-08-10 17:33:24 -04:00
Shivaram Lingamneni b54d0f8f34 add timer coalescing for the common case 2020-08-08 23:07:53 -04:00
Shivaram Lingamneni a3e5c9e98c fix #1229 2020-08-07 18:11:39 -04:00
Shivaram Lingamneni 1c4f9daae7 remove some dead code 2020-08-07 00:16:04 -04:00
Shivaram Lingamneni 55b21fa86c
Merge pull request #1227 from slingamn/issue1225.2
fix #1225
2020-08-06 01:19:39 -07:00
Shivaram Lingamneni 88b09e5919
Merge pull request #1226 from slingamn/websocket_dos
mitigate a potential DoS against websocket listeners
2020-08-06 01:08:01 -07:00
Shivaram Lingamneni 06882a9b89 fix #1225 2020-08-06 03:28:10 -04:00
Shivaram Lingamneni 7b28fc73e6
Merge pull request #1223 from hhirtz/rename
Update draft/rename impl
2020-08-05 14:02:15 -07:00
Hubert Hirtz f6d5fe812f Update draft/rename implementation
Link to the new draft PR:
<https://github.com/ircv3/ircv3-specifications/pull/420>

Changes in the spec:

- Use standard replies instead of numerics:
  <https://github.com/ircv3/ircv3-specifications/pull/420/files#diff-70e90beef48dc9cf5d784d1e179ea822R44>
- Allow RENAME to a different case:
  <https://github.com/ircv3/ircv3-specifications/pull/420/files#diff-70e90beef48dc9cf5d784d1e179ea822R42>

This commit makes oragono send the PART-JOIN fallback even on case-only
changes. This is so that clients don't have to worry about oragono's
UTF8 casefolding. See the following comments for further info:
<https://github.com/ircv3/ircv3-specifications/pull/420#issuecomment-668770837>

Misc fixes:

- Remove unused variable,
- Add missing calls to utils.SafeErrorParam,
- Don't fill replies with the user-provided "oldName", for the same
  reason as sending the PART-JOIN fallback.
2020-08-05 22:46:30 +02:00
Shivaram Lingamneni aad39024b9 mitigate a potential DoS against websocket listeners
Websocket listeners would process an arbitrary number of invalid
(non-text or blank) messages without throttling. This imposes fakelag
on such messages by treating them as blank lines.
2020-08-05 15:00:39 -04:00
Shivaram Lingamneni df8be72c6f move StringSet to utils package 2020-08-04 21:54:03 -04:00
Shivaram Lingamneni ddac7d94a8 use ChannelSet 2020-08-04 21:46:07 -04:00
Shivaram Lingamneni 15c54e80de clean up some error handling 2020-08-03 23:57:42 -04:00
Shivaram Lingamneni 9000383f88 Move config errors to call sites
Since allocating them is rare.
2020-08-03 12:55:52 -04:00
Shivaram Lingamneni 6a2fba9812 make it easier to patch out the maximum line length 2020-08-03 12:51:04 -04:00
Shivaram Lingamneni 470756cd3e fix an edge case with `/NS SASET user always-on true`
If force-nick-equals-account is disabled, then this could cause
a client with a non-reserved (or grouped) nick to become always-on.
(This can't happen with `/NS SET always-on true` because we check in
advance.)
2020-07-27 06:08:06 -04:00
Shivaram Lingamneni 027886046c clean up always-on state machine 2020-07-27 00:21:16 -04:00
Shivaram Lingamneni dc90b3c910
Merge pull request #1211 from slingamn/issue1204_echomessage.3
fix #1204
2020-07-26 03:11:27 -07:00
Shivaram Lingamneni 4bb4d02729
Merge pull request #1200 from slingamn/issue1190_remove_offerlist.1
fix #1190
2020-07-26 03:11:12 -07:00
Shivaram Lingamneni 6fbbcbc44f set up v2.3.0-unreleased 2020-07-26 06:00:24 -04:00
Shivaram Lingamneni 58be8463c9 bump version to 2.2.0 2020-07-26 05:47:18 -04:00
Shivaram Lingamneni d679d21ac0 fix #1216 2020-07-26 04:11:39 -04:00
Shivaram Lingamneni bcf581f63d fix #1214 2020-07-26 04:03:07 -04:00
Shivaram Lingamneni 6d18a1a78c tweak addEchoMessage signature 2020-07-24 02:55:46 -04:00
Shivaram Lingamneni 28d4971f36 fix #1204 2020-07-24 02:46:02 -04:00
Shivaram Lingamneni 7a16f166c5
Merge pull request #1207 from slingamn/awaystring
tweaks to auto-away
2020-07-21 23:08:50 -07:00
Shivaram Lingamneni b5f0f9a3ce
Merge pull request #1208 from slingamn/setpassword
alias for NICKSERV SET PASSWORD
2020-07-21 23:08:41 -07:00
Shivaram Lingamneni af009a5bc1 fix 2-parameter case for *playback 2020-07-21 16:33:17 -04:00
Shivaram Lingamneni e6e55bbf29 remove 'history' batch type
This was from ircv3-specifications #362, which is now obsolete.
2020-07-21 15:26:03 -04:00
Shivaram Lingamneni f193298dcd alias for NICKSERV SET PASSWORD 2020-07-21 01:05:13 -04:00
Shivaram Lingamneni eaae3165f2 don't trigger auto-away if the client is already away 2020-07-20 17:05:29 -04:00
Shivaram Lingamneni 6916dbeae0 use consistent phrase for auto-away message 2020-07-20 16:58:41 -04:00
Shivaram Lingamneni 562b85c1c0 simplify some logic 2020-07-20 14:10:43 -04:00
Shivaram Lingamneni e827bc0f9c fix #1205 2020-07-20 04:28:17 -04:00
Shivaram Lingamneni a4343bf77d bump version to 2.2.0-rc1 2020-07-19 02:25:25 -04:00
Shivaram Lingamneni 04844e0a00
Merge pull request #1196 from slingamn/changelog.1
add changelog and documentation updates
2020-07-18 22:59:45 -07:00
Shivaram Lingamneni ffd00e1aff minor optimization to Client.Friends 2020-07-17 04:53:30 -04:00
Shivaram Lingamneni 32c58c1e1f fix #1190 2020-07-17 04:19:33 -04:00
Shivaram Lingamneni 93530ae397 fix #1198 2020-07-17 02:54:43 -04:00
Shivaram Lingamneni 9e3ad5aff1 fix #1060 2020-07-15 21:57:59 -04:00
Shivaram Lingamneni a99c893f9b Merge branch 'realname_again' 2020-07-12 16:49:30 -04:00
Shivaram Lingamneni b3becbf08e clean up no-op 2020-07-12 16:47:17 -04:00
Shivaram Lingamneni 77184c1625 restore transition mechanism 2020-07-12 16:47:11 -04:00
Shivaram Lingamneni ad32a01c12
Merge pull request #1193 from slingamn/whox.2
refactor WhoFields to use value receivers
2020-07-12 13:41:49 -07:00
Shivaram Lingamneni a6d41109d0 restore multiprefix support in RPL_WHOREPLY 2020-07-12 16:40:11 -04:00
Conrad Lukawski 6f8711da3b Persist realname for always-on clients 2020-07-12 14:46:36 -04:00
Shivaram Lingamneni 358c85e697
Merge pull request #1191 from slingamn/moderation.3
enhancements to moderation (#1134, #1135)
2020-07-12 11:03:34 -07:00
Shivaram Lingamneni 0a6c1f7cc6
Merge pull request #1189 from slingamn/tagmsg_storage.1
make TAGMSG storage configurable
2020-07-12 10:57:00 -07:00
Shivaram Lingamneni 97417f4c32 refactor WhoFields to use value receivers 2020-07-12 13:45:29 -04:00
Shivaram Lingamneni bdfee9cb39
Merge pull request #1184 from jesopo/whox
implement WHOX
2020-07-11 19:36:04 -07:00
jesopo 518b21e5aa implement WHOX 2020-07-11 16:45:02 +01:00
Shivaram Lingamneni a7ca6601c7 enhancements to moderation (#1134, #1135) 2020-07-10 17:09:02 -04:00
Shivaram Lingamneni 57f2857e83
Merge pull request #1185 from slingamn/wrongsource
fix incorrect source of some nickserv messages
2020-07-09 19:44:30 -07:00
Shivaram Lingamneni bca3dd0b41 make TAGMSG storage configurable 2020-07-09 20:17:50 -04:00
Shivaram Lingamneni 8dd25f66bc review fix 2020-07-09 04:37:30 -04:00
Shivaram Lingamneni 6ea2eb367d fix #328 (implement DEFCON) 2020-07-09 02:16:51 -04:00
Shivaram Lingamneni 7dd25c6ac7 fix incorrect source of some nickserv messages 2020-07-08 21:45:13 -04:00
Shivaram Lingamneni 39269a903b fix #1179 2020-07-06 04:29:21 -04:00
Shivaram Lingamneni ed0d31e28e review feedback: fix incorrect sts-only RPL_ISUPPORT 2020-07-02 05:13:28 -04:00
Shivaram Lingamneni dca3965fd3 ensure STS-only 005 is a trailing 2020-07-02 04:00:51 -04:00
Shivaram Lingamneni f73b389ceb fix #802 2020-07-02 03:38:20 -04:00
Shivaram Lingamneni 09b74aaa37
Merge pull request #1169 from slingamn/banrace.2
fix #1166 and #1168
2020-07-01 02:41:46 -07:00
Shivaram Lingamneni 0b0b1499b0 fix #1167 2020-07-01 04:20:27 -04:00
Shivaram Lingamneni 067e62ad5e fix #1166 and #1168 2020-07-01 03:52:55 -04:00
Shivaram Lingamneni 79764cd549
Merge pull request #1163 from slingamn/list_issue1161
fix #1161
2020-06-30 17:43:48 -07:00
Shivaram Lingamneni 70f533ee07 fix #1155 2020-06-29 21:29:28 -04:00
Shivaram Lingamneni a7107bfb67
Merge pull request #1156 from slingamn/lastseen
tweaks to lastSeen persistence
2020-06-29 18:04:55 -07:00
Shivaram Lingamneni 696980367d fix #1161 2020-06-29 15:41:29 -04:00
Shivaram Lingamneni fe2332f0cd remove a stray documentation line 2020-06-29 02:12:24 -04:00
Shivaram Lingamneni 0f04acaa40 persist last seen on shutdown 2020-06-29 00:38:05 -04:00
Shivaram Lingamneni a38d375bda delete always-on modes on unregistration 2020-06-29 00:38:05 -04:00
Shivaram Lingamneni e22adf47ca increase write interval for lastSeen 2020-06-29 00:38:05 -04:00
Shivaram Lingamneni 9aa53aa3aa update lastSeen on reattach 2020-06-29 00:38:05 -04:00
Shivaram Lingamneni d7a62223a0
Merge pull request #1123 from clukawski/no-ctcp-user-mode
Add +T no-CTCP usermode
2020-06-27 21:13:24 -07:00
Conrad Lukawski fca2900918 Add +T no-CTCP usermode 2020-06-28 00:04:42 -04:00
Shivaram Lingamneni 089a267070 delete some unused fields 2020-06-24 16:50:07 -04:00
Shivaram Lingamneni ba68358c21
Merge pull request #1152 from slingamn/utf8.1
fix #1151
2020-06-23 01:02:59 -07:00
Shivaram Lingamneni 8cadc7340a don't trim line endings in IRCStreamConn
Doesn't help if the line ends with regular \n only,
and the parser has to account for \r and \n anyway
2020-06-23 03:25:20 -04:00
Shivaram Lingamneni 28a0ec86b5 simplify Socket.Read 2020-06-23 03:25:20 -04:00
Shivaram Lingamneni 7ee7b1aab5
Merge pull request #1150 from slingamn/monitor.1
fix #1053, #1083
2020-06-22 20:25:27 -07:00
Shivaram Lingamneni 0e7557c12d
Merge pull request #1149 from slingamn/issue1059_certfp
fix #1059
2020-06-22 20:23:15 -07:00
Shivaram Lingamneni be138e4d71 make comment consistent with review fix 2020-06-22 22:34:09 -04:00
Shivaram Lingamneni 58d3d1276f review fix 2020-06-22 18:53:54 -04:00
Shivaram Lingamneni 21e604860f add an explanatory comment 2020-06-22 15:56:47 -04:00
Shivaram Lingamneni a4f9e08a85 fix #1151 2020-06-22 15:50:28 -04:00
Shivaram Lingamneni cb530050f1 fix #1053, #1083 2020-06-21 23:51:31 -04:00
Shivaram Lingamneni 97789cde7e fix #1059 2020-06-21 18:42:45 -04:00
Shivaram Lingamneni 01bd04a8ff fix #1050 2020-06-21 18:32:57 -04:00
Shivaram Lingamneni ca79da87b1 fix disabling of autoreplay-missed 2020-06-18 04:32:54 -04:00
Shivaram Lingamneni 17cd831319 fix #1144 2020-06-18 03:38:00 -04:00
Shivaram Lingamneni 91fa3b30b0 fix the corresponding bug for certfp authentication 2020-06-17 03:09:20 -04:00
Shivaram Lingamneni 9c26c45607 fix a bug in authscript fallback handling 2020-06-17 02:19:25 -04:00
Shivaram Lingamneni 114e359347 remove ldap 2020-06-17 02:15:05 -04:00
Daniel Oaks fb55cc3390 Ignore some dodgy TL strings, fix another dodgy string 2020-06-16 20:33:10 +10:00
Shivaram Lingamneni 784078d693 fix bug introduced in #1138 2020-06-16 05:10:09 -04:00