GitHub/ergo
3
0
Fork 0
mirror of https://github.com/ergochat/ergo.git synced 2024-11-15 08:29:31 +01:00
Code Issues Projects Releases Wiki Activity
5,006 Commits 22 Branches 70 Tags 46 MiB
66bf6244f3
Commit Graph

408 Commits

Author SHA1 Message Date
Shivaram Lingamneni
5c7df07d91
Merge pull request #1936 from slingamn/nick_empty 
fix #1933
 2022-04-25 18:02:31 -04:00
Shivaram Lingamneni
2b8eb93c00 clean up magic numbers 2022-04-24 11:57:21 -04:00
Shivaram Lingamneni
61fd7a2534 fix the rest of #1933 
`NICK :` pre-registration needs to be special-cased to immediately
send ERR_NONICKNAMEGIVEN (unlike erroneous nonempty nicknames,
which are processed when registration is complete)
 2022-04-24 01:39:45 -04:00
Shivaram Lingamneni
1f08c97238
Merge pull request #1926 from slingamn/readmarker.6 
implement draft/read-marker capability
 2022-04-08 01:33:06 -04:00
Shivaram Lingamneni
2fb8b836db fix #1928 
LIST should not return ERR_NOSUCHCHANNEL for nonexistent channels
 2022-04-07 11:44:23 -04:00
Shivaram Lingamneni
32f7868bfd implement draft/read-marker capability 2022-03-30 23:16:09 -04:00
Shivaram Lingamneni
a549827f17 upgrade to go 1.18, use generics 2022-03-30 00:44:51 -04:00
William Rehwinkel
4010f3fc02
Fix #1911 +s channels don't appear in /list even though on the channel (#1923) 
* Fix #1911 +s channels don't appear in /list even though on the channel

* use channel.HasClient instead of custom iterative checker
 2022-02-28 20:31:16 -05:00
Shivaram Lingamneni
0afa7edffe fix #1895 
Include server start time in INFO output.
 2022-02-08 07:38:11 -05:00
Shivaram Lingamneni
fcb86c54f7 fix #1906 
Having the 'samode' capability made all KICK commands privileged. This appears
to have been introduced unintentionally by 42316bc04f and I can't find
any discussion of a rationale. Since this goes against our policy that all
ircop (as opposed to channel founder) privileges must be invoked explicitly
(e.g. SAJOIN, SAMODE), remove this.
 2022-02-07 19:06:31 -05:00
Shivaram Lingamneni
dba5d3faae show arbitrary IP in WHOX 
This extends #1650 to cover WHO as well as WHOIS
 2022-01-09 17:24:24 -05:00
Shivaram Lingamneni
d174b5aad6 add disambiguating numbers in translated strings 2022-01-02 17:36:12 -05:00
Shivaram Lingamneni
76f7748c8a correctly account for nickname in CAP LS arithmetic 
The arithmetic was assuming that the nickname is * (which it is
pre-registration). However, we were sending the actual nickname
post-registration. It would be simpler to always send *, but it
appears that the nickname is actually required by the spec:

>Replies from the server must [sic] contain the client identifier name or
>asterisk if one is not yet available.
 2021-12-16 01:59:36 -05:00
Shivaram Lingamneni
f3f805acb8 send * for WHOX o (oplevel) instead of 0 
Jobe points out that 0 is a valid oplevel in some contexts,
* is a better placeholder for "unimplemented".
 2021-12-12 03:05:56 -05:00
Shivaram Lingamneni
cb757c703d change FAIL AUTHENTICATE VERIFICATION_REQUIRED to be a NOTE 
See discussion on #1852
 2021-12-01 12:16:03 -05:00
Shivaram Lingamneni
72959eb1cf
Merge pull request #1852 from slingamn/fail_authenticate 
add FAIL AUTHENTICATE VERIFICATION_REQUIRED
 2021-11-30 20:35:33 -05:00
Shivaram Lingamneni
7d66368274 add FAIL AUTHENTICATE VERIFICATION_REQUIRED 
From discussion with @emersion, this will help with UX if people try to
log into their unverified accounts.
 2021-11-30 15:27:25 -05:00
Shivaram Lingamneni
9ff4047fa6 fix #1840 
Account registrations pending verification should produce a logline and
send a sno.
 2021-11-30 03:18:01 -05:00
Shivaram Lingamneni
ac91beabfd
Merge pull request #1835 from slingamn/who.1 
fix two WHO bugs
 2021-11-16 21:45:40 -05:00
Shivaram Lingamneni
bc5c2a1250 fix casefolding issue in muting RELAYMSG 
Reported by @mogad0n; the mute mask was being case-canonicalized,
but the RELAYMSG identifier wasn't being case-canonicalized before
the check.
 2021-11-16 18:39:38 -05:00
Shivaram Lingamneni
2038763e10 fix #1730 
`WHO #channel o` is supposed to return only server operators.
This is RFC1459 cruft; just return an empty list in this case.
 2021-11-14 15:13:56 -05:00
Shivaram Lingamneni
62b2d0341e fix #1831 
RPL_ENDOFWHO should send the original, un-normalized mask
 2021-11-14 13:41:27 -05:00
Shivaram Lingamneni
dc75b24d23 clarify comment on CAP byte arithmetic 2021-11-07 13:32:18 -05:00
Shivaram Lingamneni
4749d7e776 fix #1676, take 2 
Ensure the pagination window is full by making sure that every history item
gets a replay line in CHATHISTORY output, even TAGMSG.
 2021-11-01 04:34:59 -04:00
Shivaram Lingamneni
3ec5ffa340 Revert "fix #1676" 
This reverts commit 5bbee02fe6.
 2021-11-01 04:34:59 -04:00
Shivaram Lingamneni
5bbee02fe6 fix #1676 
Fix various pagination issues with CHATHISTORY; also undo #491
(msgid munging).
 2021-10-29 04:50:24 -04:00
Alex Jaspersen
53a7e8c334 Send snomask for channel mode changes via SAMODE. 
Fixes #1787
 2021-10-03 17:15:01 -07:00
Shivaram Lingamneni
aa969b7ff7 fix #1530 
Warn if the user sent, e.g., /QUOTE /SAMODE instead of /QUOTE SAMODE
 2021-09-05 20:14:13 -04:00
Shivaram Lingamneni
9b6ec04ca5
Merge pull request #1761 from delthas/feature-extended-monitor 
Add support for extended-monitor
 2021-08-26 10:14:31 -04:00
Shivaram Lingamneni
fea8cc1b9a
Merge pull request #1778 from ProgVal/empty-realname 
Add missing argument to ERR_NEEDMOREPARAMS on USER commands.
 2021-08-13 16:58:53 -04:00
Valentin Lorentz
a90fbf9f2c Add missing argument to ERR_NEEDMOREPARAMS on USER commands. 
Refs:

* other instances in the codebase
* https://defs.ircdocs.horse/defs/numerics.html#err-needmoreparams-461
* https://modern.ircdocs.horse/#errneedmoreparams-461
 2021-08-13 21:10:46 +02:00
Valentin Lorentz
f33f41b0eb Make kick messages default to the kicker name instead of the kicked 
For consistency with RFC2812, Bahamut, Hybrid, Insp, Plexus4, Unreal.
https://datatracker.ietf.org/doc/html/rfc2812#section-3.2.8

At the expense of consistency with chary/solanum, irc2, and ircu2.
 2021-08-13 20:16:37 +02:00
Shivaram Lingamneni
117401f293 fix SCRAM not supporting client IDs 
reported by @Mikaela
 2021-08-03 11:47:00 -04:00
Shivaram Lingamneni
ebe1f84d64 consolidate login throttle checks 
We can check once during initialization of the SASL session, e.g.
on receiving `AUTHENTICATE PLAIN` or `AUTHENTICATE EXTERNAL`
 2021-07-30 14:06:13 -04:00
Shivaram Lingamneni
41822813c0 clean up redundant check for sasl mechanism 2021-07-30 14:03:40 -04:00
Shivaram Lingamneni
e1401934df implement SCRAM-SHA-256 2021-07-30 12:20:13 -04:00
delthas
7fde04ea94 Add support for extended-monitor 
See: https://github.com/ircv3/ircv3-specifications/pull/466
 2021-07-24 20:52:03 +02:00
Pratyush Desai
99610eae4b add timeCreated to /uban list output 2021-07-14 12:36:45 +05:30
Valentin Lorentz
f58f8531b2 Restore support for multiple channels + single user 2021-07-12 20:59:05 +02:00
Val Lorentz
54c5d35193 Add support for KICK #chan user1,user2 
This is one of the two cases of [RFC 2812 kicks](https://datatracker.ietf.org/doc/html/rfc2812#section-3.2.8):
even when there are multiple user targets, the RFC (and Unreal
and Inspircd and probably others) allows a single channel name.
 2021-07-10 11:13:52 +02:00
Shivaram Lingamneni
907f82a27e
Merge pull request #1741 from slingamn/greylisting.3 
user visible email errors, email timeouts
 2021-07-09 07:22:03 -04:00
Shivaram Lingamneni
59bddd066f update draft/register -> draft/account-registration 
Fixes #1740
 2021-07-07 07:37:46 -04:00
Shivaram Lingamneni
46572b871f expose a user-visible error if direct email sending fails 
See #1659
 2021-07-07 07:21:22 -04:00
Shivaram Lingamneni
d0801e45a8 fix #1731 
CHATHISTORY INVALID_TARGETS was missing the subcommand parameter
 2021-07-04 01:37:59 -04:00
Shivaram Lingamneni
f07524111c
Merge pull request #1702 from ajaspers/whowas 
Show real IP in WHOWAS to opers with ban capability.
 2021-06-22 02:28:56 -04:00
Alex Jaspersen
b6264a43b6 Rename "realIP" to "ip" in WhoWas struct. 
It could be the real IP or the proxied IP.
 2021-06-20 11:13:18 -07:00
Shivaram Lingamneni
51c207dc80 fix #1703 
`WHOWAS :` should return an error numeric instead of an empty response
 2021-06-20 14:12:13 -04:00
Alex Jaspersen
e5c2588eab Show real IP in WHOWAS to opers with ban capability. 2021-06-20 10:26:30 -07:00
Shivaram Lingamneni
4910aefa37 use ergochat/irc-go instead of goshuirc/irc-go 2021-06-18 02:43:25 -04:00
Shivaram Lingamneni
ec48966b68 fix #1661 
If the relay bot and the owner share an IP, legacy bots that identify users
by user@host could misinterpret relayed lines as coming from the bot owner.
Try to avoid this by using the bot's account cloak where applicable.
 2021-05-27 11:43:21 -04:00