GitHub/ergo
3
0
Fork 0
mirror of https://github.com/ergochat/ergo.git synced 2024-11-30 07:59:24 +01:00
Code Issues Projects Releases Wiki Activity
5,302 Commits 22 Branches 70 Tags 46 MiB
2aec5e167c
Commit Graph

450 Commits

Author SHA1 Message Date
Shivaram Lingamneni
0afa7edffe fix #1895 
Include server start time in INFO output.
 2022-02-08 07:38:11 -05:00
Shivaram Lingamneni
fcb86c54f7 fix #1906 
Having the 'samode' capability made all KICK commands privileged. This appears
to have been introduced unintentionally by 42316bc04f and I can't find
any discussion of a rationale. Since this goes against our policy that all
ircop (as opposed to channel founder) privileges must be invoked explicitly
(e.g. SAJOIN, SAMODE), remove this.
 2022-02-07 19:06:31 -05:00
Shivaram Lingamneni
dba5d3faae show arbitrary IP in WHOX 
This extends #1650 to cover WHO as well as WHOIS
 2022-01-09 17:24:24 -05:00
Shivaram Lingamneni
d174b5aad6 add disambiguating numbers in translated strings 2022-01-02 17:36:12 -05:00
Shivaram Lingamneni
76f7748c8a correctly account for nickname in CAP LS arithmetic 
The arithmetic was assuming that the nickname is * (which it is
pre-registration). However, we were sending the actual nickname
post-registration. It would be simpler to always send *, but it
appears that the nickname is actually required by the spec:

>Replies from the server must [sic] contain the client identifier name or
>asterisk if one is not yet available.
 2021-12-16 01:59:36 -05:00
Shivaram Lingamneni
f3f805acb8 send * for WHOX o (oplevel) instead of 0 
Jobe points out that 0 is a valid oplevel in some contexts,
* is a better placeholder for "unimplemented".
 2021-12-12 03:05:56 -05:00
Shivaram Lingamneni
cb757c703d change FAIL AUTHENTICATE VERIFICATION_REQUIRED to be a NOTE 
See discussion on #1852
 2021-12-01 12:16:03 -05:00
Shivaram Lingamneni
72959eb1cf
Merge pull request #1852 from slingamn/fail_authenticate 
add FAIL AUTHENTICATE VERIFICATION_REQUIRED
 2021-11-30 20:35:33 -05:00
Shivaram Lingamneni
7d66368274 add FAIL AUTHENTICATE VERIFICATION_REQUIRED 
From discussion with @emersion, this will help with UX if people try to
log into their unverified accounts.
 2021-11-30 15:27:25 -05:00
Shivaram Lingamneni
9ff4047fa6 fix #1840 
Account registrations pending verification should produce a logline and
send a sno.
 2021-11-30 03:18:01 -05:00
Shivaram Lingamneni
ac91beabfd
Merge pull request #1835 from slingamn/who.1 
fix two WHO bugs
 2021-11-16 21:45:40 -05:00
Shivaram Lingamneni
bc5c2a1250 fix casefolding issue in muting RELAYMSG 
Reported by @mogad0n; the mute mask was being case-canonicalized,
but the RELAYMSG identifier wasn't being case-canonicalized before
the check.
 2021-11-16 18:39:38 -05:00
Shivaram Lingamneni
2038763e10 fix #1730 
`WHO #channel o` is supposed to return only server operators.
This is RFC1459 cruft; just return an empty list in this case.
 2021-11-14 15:13:56 -05:00
Shivaram Lingamneni
62b2d0341e fix #1831 
RPL_ENDOFWHO should send the original, un-normalized mask
 2021-11-14 13:41:27 -05:00
Shivaram Lingamneni
dc75b24d23 clarify comment on CAP byte arithmetic 2021-11-07 13:32:18 -05:00
Shivaram Lingamneni
4749d7e776 fix #1676, take 2 
Ensure the pagination window is full by making sure that every history item
gets a replay line in CHATHISTORY output, even TAGMSG.
 2021-11-01 04:34:59 -04:00
Shivaram Lingamneni
3ec5ffa340 Revert "fix #1676" 
This reverts commit 5bbee02fe6.
 2021-11-01 04:34:59 -04:00
Shivaram Lingamneni
5bbee02fe6 fix #1676 
Fix various pagination issues with CHATHISTORY; also undo #491
(msgid munging).
 2021-10-29 04:50:24 -04:00
Alex Jaspersen
53a7e8c334 Send snomask for channel mode changes via SAMODE. 
Fixes #1787
 2021-10-03 17:15:01 -07:00
Shivaram Lingamneni
aa969b7ff7 fix #1530 
Warn if the user sent, e.g., /QUOTE /SAMODE instead of /QUOTE SAMODE
 2021-09-05 20:14:13 -04:00
Shivaram Lingamneni
9b6ec04ca5
Merge pull request #1761 from delthas/feature-extended-monitor 
Add support for extended-monitor
 2021-08-26 10:14:31 -04:00
Shivaram Lingamneni
fea8cc1b9a
Merge pull request #1778 from ProgVal/empty-realname 
Add missing argument to ERR_NEEDMOREPARAMS on USER commands.
 2021-08-13 16:58:53 -04:00
Valentin Lorentz
a90fbf9f2c Add missing argument to ERR_NEEDMOREPARAMS on USER commands. 
Refs:

* other instances in the codebase
* https://defs.ircdocs.horse/defs/numerics.html#err-needmoreparams-461
* https://modern.ircdocs.horse/#errneedmoreparams-461
 2021-08-13 21:10:46 +02:00
Valentin Lorentz
f33f41b0eb Make kick messages default to the kicker name instead of the kicked 
For consistency with RFC2812, Bahamut, Hybrid, Insp, Plexus4, Unreal.
https://datatracker.ietf.org/doc/html/rfc2812#section-3.2.8

At the expense of consistency with chary/solanum, irc2, and ircu2.
 2021-08-13 20:16:37 +02:00
Shivaram Lingamneni
117401f293 fix SCRAM not supporting client IDs 
reported by @Mikaela
 2021-08-03 11:47:00 -04:00
Shivaram Lingamneni
ebe1f84d64 consolidate login throttle checks 
We can check once during initialization of the SASL session, e.g.
on receiving `AUTHENTICATE PLAIN` or `AUTHENTICATE EXTERNAL`
 2021-07-30 14:06:13 -04:00
Shivaram Lingamneni
41822813c0 clean up redundant check for sasl mechanism 2021-07-30 14:03:40 -04:00
Shivaram Lingamneni
e1401934df implement SCRAM-SHA-256 2021-07-30 12:20:13 -04:00
delthas
7fde04ea94 Add support for extended-monitor 
See: https://github.com/ircv3/ircv3-specifications/pull/466
 2021-07-24 20:52:03 +02:00
Pratyush Desai
99610eae4b add timeCreated to /uban list output 2021-07-14 12:36:45 +05:30
Valentin Lorentz
f58f8531b2 Restore support for multiple channels + single user 2021-07-12 20:59:05 +02:00
Val Lorentz
54c5d35193 Add support for KICK #chan user1,user2 
This is one of the two cases of [RFC 2812 kicks](https://datatracker.ietf.org/doc/html/rfc2812#section-3.2.8):
even when there are multiple user targets, the RFC (and Unreal
and Inspircd and probably others) allows a single channel name.
 2021-07-10 11:13:52 +02:00
Shivaram Lingamneni
907f82a27e
Merge pull request #1741 from slingamn/greylisting.3 
user visible email errors, email timeouts
 2021-07-09 07:22:03 -04:00
Shivaram Lingamneni
59bddd066f update draft/register -> draft/account-registration 
Fixes #1740
 2021-07-07 07:37:46 -04:00
Shivaram Lingamneni
46572b871f expose a user-visible error if direct email sending fails 
See #1659
 2021-07-07 07:21:22 -04:00
Shivaram Lingamneni
d0801e45a8 fix #1731 
CHATHISTORY INVALID_TARGETS was missing the subcommand parameter
 2021-07-04 01:37:59 -04:00
Shivaram Lingamneni
f07524111c
Merge pull request #1702 from ajaspers/whowas 
Show real IP in WHOWAS to opers with ban capability.
 2021-06-22 02:28:56 -04:00
Alex Jaspersen
b6264a43b6 Rename "realIP" to "ip" in WhoWas struct. 
It could be the real IP or the proxied IP.
 2021-06-20 11:13:18 -07:00
Shivaram Lingamneni
51c207dc80 fix #1703 
`WHOWAS :` should return an error numeric instead of an empty response
 2021-06-20 14:12:13 -04:00
Alex Jaspersen
e5c2588eab Show real IP in WHOWAS to opers with ban capability. 2021-06-20 10:26:30 -07:00
Shivaram Lingamneni
4910aefa37 use ergochat/irc-go instead of goshuirc/irc-go 2021-06-18 02:43:25 -04:00
Shivaram Lingamneni
ec48966b68 fix #1661 
If the relay bot and the owner share an IP, legacy bots that identify users
by user@host could misinterpret relayed lines as coming from the bot owner.
Try to avoid this by using the bot's account cloak where applicable.
 2021-05-27 11:43:21 -04:00
Shivaram Lingamneni
77313e20ad fix #1647 
Send a full NUH with RELAYMSG.

Also fix client-only tags with RELAYMSG.
 2021-05-27 02:00:59 -04:00
Shivaram Lingamneni
23c7218bf1 first pass at renaming Oragono to Ergo 2021-05-26 15:55:24 -04:00
Shivaram Lingamneni
ba21987d03 remove draft/resume-0.5 2021-05-18 23:27:46 -04:00
Shivaram Lingamneni
75f89a9f1f fix FAIL REGISTER INVALID_USERNAME case 2021-04-25 17:16:34 -04:00
Shivaram Lingamneni
0b414cb158
Merge pull request #1625 from slingamn/cleanup_star.2 
fix #1615
 2021-04-21 09:27:54 -04:00
jesopo
4700d4c048 make gofmt happey :)) 2021-04-20 11:05:05 +00:00
jesopo
7345ecba48 don't Sprintf for each match, Details().nick -> .Nick() 2021-04-20 11:04:24 +00:00
jesopo
0a1537f928 support $$server and $#hostname global messages 2021-04-20 10:46:43 +00:00
Shivaram Lingamneni
0d05ab4ff4 fix #1615 
Remove the CHATHISTORY * and znc.in/playback *self targets,
clean up associated database code, add new mechanisms to play
all missed DMs.
 2021-04-19 08:54:40 -04:00
Shivaram Lingamneni
da216fc699 fix #1577 
Remove debugging loglines for truncation
 2021-04-19 07:06:49 -04:00
Shivaram Lingamneni
18b6e2f1cd implement CHATHISTORY TARGETS 2021-04-07 05:40:39 -04:00
Shivaram Lingamneni
4052cd12fe fix #1592 
Implements the new `CHATHISTORY LISTCORRESPONDENTS` API.
 2021-04-06 00:46:07 -04:00
Shivaram Lingamneni
e447c61c73 fix #1596 
All truncation must be made UTF8-safe.
 2021-03-18 03:49:12 -04:00
Shivaram Lingamneni
cd43fae478
Merge pull request #1597 from slingamn/away_session.1 
fix #1531
 2021-03-18 03:28:03 -04:00
Shivaram Lingamneni
70b20750aa fix #1531 
AWAY status should be tracked per-session:

1. With auto-away enabled, away status is aggregated across sessions
   (if any session is not away, the client is not away, else use
   the away status that was set most recently)
2. With auto-away disabled, we get the legacy behavior where AWAY
   applies directly to the client
 2021-03-18 02:53:18 -04:00
Shivaram Lingamneni
1efde964e1 Fix #1562 
Implement the new bot mode spec:
https://github.com/ircv3/ircv3-specifications/pull/439
 2021-03-17 14:36:52 -04:00
Shivaram Lingamneni
fe8e6551c3 fix #1502 
RELAYMSG should respect mutes
 2021-03-11 01:21:03 -05:00
Shivaram Lingamneni
131eb229bc use the new irc-go identifiers 2021-03-10 20:07:43 -05:00
Shivaram Lingamneni
03185ea4a9 deprecate message truncation 
Implements #1577, but the issue should remain open until we clean up
the debugging loglines.
 2021-03-04 22:29:34 -05:00
Alex Jaspersen
23164054f6 Send 477 ERR_NEEDREGGEDNICK when an unregistered user messages a +R user. 
Fixes #1064.
 2021-03-03 19:36:29 -08:00
Shivaram Lingamneni
8180c2b572 improve compatibility with published register spec 
1. Send COMPLETE_CONNECTION_REQUIRED instead of DISALLOWED
2. Include the account name in all FAIL messages
 2021-02-28 17:14:10 -05:00
Shivaram Lingamneni
e957a89ee2 bump irc-go for the IRCMessage rename 2021-02-15 11:27:04 -05:00
Mikaela Suomalainen
4340da9b6e
docs/USERGUIDE.md & irc/handlers.go: fix spelling of WeeChat 2021-02-13 14:44:13 +02:00
Shivaram Lingamneni
42316bc04f fix #1176 
Transition most "is an operator" checks to require a specific operator
capability
 2021-02-09 22:07:06 -05:00
Shivaram Lingamneni
cc6be14c1d fix #1507 
Registered channels should be eagerly created on startup, and should
remain (and be visible in LIST) even when they have no members.
 2021-02-04 15:26:03 -05:00
Shivaram Lingamneni
07fa2ecb3e allow UBAN <ip> REQUIRE-SASL 2021-01-22 09:38:40 -05:00
Shivaram Lingamneni
2e7cf3cc1e
Merge pull request #1496 from slingamn/jointime.1 
fix #1490
 2021-01-21 01:20:45 -05:00
Shivaram Lingamneni
4a48e52518 fix #1490 
Track channel join times, use them to optionally enforce history access
restrictions
 2021-01-20 21:13:18 -05:00
Shivaram Lingamneni
bb5276553d initial UBAN implementation 2021-01-19 08:49:45 -05:00
Shivaram Lingamneni
64bc363cf1 fix #1443 
Improve auditability of sensitive operator actions
 2021-01-19 06:45:30 -05:00
Shivaram Lingamneni
e195854851 fix #1442 
strip local_ from oper capab names, also consolidate unban into ban
 2021-01-19 06:45:30 -05:00
Shivaram Lingamneni
d1f8317180 fix #1479 
Give Tor clients who authenticate via SASL a unique cloak, so chanops
can ban *!*@tor-network.onion and still allow authenticated Tor users
 2021-01-12 08:40:13 -05:00
Shivaram Lingamneni
ec375f5bdc consolidate ArgsToStrings 2020-12-30 00:41:34 -05:00
Shivaram Lingamneni
0c9ecbade7 ERR_HELPNOTFOUND should take the nick as a parameter 2020-12-29 13:19:46 -05:00
Shivaram Lingamneni
6965031aa9 fix #1472 
HELP responses weren't taking the client nickname as a parameter,
as is standard.
 2020-12-29 05:20:18 -05:00
Shivaram Lingamneni
514a2e613f fix #1468 2020-12-21 22:07:48 -05:00
Shivaram Lingamneni
cc2b6d27a0 fix critical bugs in RENAME 
Channel rename (both of registered and unregistered channels) would leave
the old name unreclaimable.
 2020-12-14 23:35:46 -05:00
Shivaram Lingamneni
ba72d3acfc implement a channel forwarding mode 
Fixes #1260
 2020-12-14 22:38:23 -05:00
Shivaram Lingamneni
47f7b9a76e make CAP LS/LIST respect the MaxLineLen constant 2020-12-13 15:44:10 -05:00
Shivaram Lingamneni
84e3b5d77b stop autocreating d-lines for throttle violations 
This didn't work correctly for IPv6 or custom nets.
/UNDLINE IP can temporarily be used to reset the throttle.
 2020-12-08 22:01:23 -05:00
Shivaram Lingamneni
da2d4ca130 make overridden services hostname appear in chanserv 2020-12-07 02:29:18 -05:00
Shivaram Lingamneni
66d90bef5e change FAIL codes from NOT_PRIVED to PRIVS_NEEDED 2020-12-06 21:01:44 -05:00
Shivaram Lingamneni
7bdbb01238 fix #1428 
Tor listeners should never see an STS cap.

Add an undocumented 'hide-sts' key for listeners that hides the STS cap.
This can be used if the listener is secured at layer 3 or 4 (VPNs,
E2E mixnets). It will be necessary to add the relevant IPs to `secure-nets`.
 2020-12-05 23:06:23 -05:00
Shivaram Lingamneni
01291ceadd fix #1417 
Allow `JOIN 0` with a confirmation code
 2020-12-01 14:23:47 -05:00
Shivaram Lingamneni
5edfcced0a
Merge pull request #1415 from slingamn/issue1409_invite_history.1 
fix #1409
 2020-11-29 19:47:22 -08:00
Shivaram Lingamneni
32bbde49a8 fix #1409 
Record INVITE in DM history for the benefit of offline always-on clients
 2020-11-29 22:12:06 -05:00
Shivaram Lingamneni
c62956f708 fix #1396 
* Defer account login snomask until after connection registration is complete
* Don't send account-notify for pre-registration clients
 2020-11-29 20:20:26 -05:00
Shivaram Lingamneni
9214d978d0 refactor services prefixes and notice handlers 2020-11-29 00:02:26 -05:00
Shivaram Lingamneni
8ad6a53433 fix duplicated nicks in kline message 2020-11-10 11:17:17 -05:00
Shivaram Lingamneni
9374a75c7a implement FAIL CHATHISTORY INVALID_TARGET 2020-11-04 01:54:59 -05:00
Shivaram Lingamneni
6513136ea3 fix #1366 
Include an 'r' flag in RPL_WHOREPLY for registered nicks
 2020-10-29 14:25:28 -04:00
Shivaram Lingamneni
1f6afa31d6 fix #1274 
Enhancements to NS SUSPEND, including stored metadata and the ability
to list suspensions
 2020-10-27 18:30:03 -04:00
Shivaram Lingamneni
b57820150e no-op fix to SETNAME workaround 2020-10-26 18:06:06 -04:00
Shivaram Lingamneni
9c4b086113
Merge pull request #1355 from slingamn/invite 
security enhancements for INVITE
 2020-10-26 13:30:41 -07:00
Shivaram Lingamneni
5dcb2bb60c enhancements to SETNAME 
Address SETNAME UX problems reported by @KoraggKnightWolf in #oragono:

1. No feedback by default on success or failure
2. Multi-word realnames are not correctly interpreted by some clients
 2020-10-26 15:31:51 -04:00
Shivaram Lingamneni
4b1e6b04c4 add UNINVITE command (#1171) 2020-10-25 22:16:19 -04:00
Shivaram Lingamneni
a37a91694c fix #1337 2020-10-19 10:52:38 -04:00
Shivaram Lingamneni
1d74185b7d fix #1322 2020-10-13 00:38:23 -04:00