Merge pull request #1215 from slingamn/issue1214_saregister

fix #1214

irc/accounts.go

@@ -891,19 +891,34 @@ func (am *AccountManager) Verify(client *Client, account string, code string) er
 	}
 	if client != nil {
 		am.Login(client, clientAccount)
+		if client.AlwaysOn() {
+			client.markDirty(IncludeRealname)
 		}
+	}
+	// we may need to do nick enforcement here:
 	_, method := am.EnforcementStatus(casefoldedAccount, skeleton)
-	if method != NickEnforcementNone {
-		currentClient := am.server.clients.Get(casefoldedAccount)
-		if currentClient == nil || currentClient == client || currentClient.Account() == casefoldedAccount {
-			return nil
-		}
 	if method == NickEnforcementStrict {
+		currentClient := am.server.clients.Get(casefoldedAccount)
+		if currentClient != nil && currentClient != client && currentClient.Account() != casefoldedAccount {
 			am.server.RandomlyRename(currentClient)
 		}
 	}
-	if client.AlwaysOn() {
+	// #1216: we may have created an always-on client
-		client.markDirty(IncludeRealname)
+	if client == nil {
+		config := am.server.Config()
+		if persistenceEnabled(config.Accounts.Multiclient.AlwaysOn, PersistentUnspecified) {
+			accountData, err := am.LoadAccount(account)
+			if err != nil {
+				return err
+			}
+			am.server.AddAlwaysOnClient(
+				accountData,
+				nil,
+				nil,
+				config.Accounts.defaultUserModes,
+				"",
+			)
+		}
 	}
 	return nil
 }