From bfae13aad9ce5fe927f40597a813df8001d2b933 Mon Sep 17 00:00:00 2001 From: Shivaram Lingamneni Date: Tue, 16 Nov 2021 18:39:38 -0500 Subject: [PATCH] fix casefolding issue in muting RELAYMSG Reported by @mogad0n; the mute mask was being case-canonicalized, but the RELAYMSG identifier wasn't being case-canonicalized before the check. --- irc/handlers.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/irc/handlers.go b/irc/handlers.go index e3977668..618f2fae 100644 --- a/irc/handlers.go +++ b/irc/handlers.go @@ -2678,7 +2678,7 @@ func relaymsgHandler(server *Server, client *Client, msg ircmsg.Message, rb *Res message := utils.MakeMessage(rawMessage) nick := msg.Params[1] - _, err := CasefoldName(nick) + cfnick, err := CasefoldName(nick) if err != nil { rb.Add(nil, server.name, "FAIL", "RELAYMSG", "INVALID_NICK", client.t("Invalid nickname")) return false @@ -2687,7 +2687,7 @@ func relaymsgHandler(server *Server, client *Client, msg ircmsg.Message, rb *Res rb.Add(nil, server.name, "FAIL", "RELAYMSG", "INVALID_NICK", fmt.Sprintf(client.t("Relayed nicknames MUST contain a relaymsg separator from this set: %s"), config.Server.Relaymsg.Separators)) return false } - if channel.relayNickMuted(nick) { + if channel.relayNickMuted(cfnick) { rb.Add(nil, server.name, "FAIL", "RELAYMSG", "BANNED", fmt.Sprintf(client.t("%s is banned from relaying to the channel"), nick)) return false }