GitHub/ergo
3
0
Fork 0
mirror of https://github.com/ergochat/ergo.git synced 2024-11-25 05:19:25 +01:00
Code Issues Projects Releases Wiki Activity

fix handling of +k with an empty key parameter

Browse Source 
This should be disallowed; `MODE #keytest +k :` should just be an error.
This commit is contained in:
Shivaram Lingamneni 2021-08-10 15:11:11 -04:00
parent bbb52bf692
commit abfb8442ab
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
irc/modes.go
View File

@ -148,11 +148,7 @@ func ParseDefaultUserModes(rawModes *string) modes.Modes {
// #1021: channel key must be valid as a non-final parameter // #1021: channel key must be valid as a non-final parameter
func validateChannelKey(key string) bool { func validateChannelKey(key string) bool {
// empty string is valid in this context because it unsets the mode return key != "" && key[0] != ':' && strings.IndexByte(key, ' ') == -1
if len(key) == 0 {
return true
}
return key[0] != ':' && strings.IndexByte(key, ' ') == -1
} }
// ApplyChannelModeChanges applies a given set of mode changes. // ApplyChannelModeChanges applies a given set of mode changes.