GitHub/ergo
3
0
Fork 0
mirror of https://github.com/ergochat/ergo.git synced 2024-11-25 21:39:25 +01:00
Code Issues Projects Releases Wiki Activity

fix spurious bidi violations when casefolding the nickmask of an RTL nick

Browse Source
This commit is contained in:
Shivaram Lingamneni 2019-01-28 13:36:15 -05:00
parent 14ce8d850e
commit a2a9788f39
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
irc/client.go
View File

@ -759,15 +759,15 @@ func (client *Client) updateNickMaskNoMutex() {
client.hostname = client.rawHostname
}
nickMaskString := fmt.Sprintf("%s!%s@%s", client.nick, client.username, client.hostname)
nickMaskCasefolded, err := Casefold(nickMaskString)
cfusername, _ := Casefold(client.username) // we already checked for errors in SetNames
cfhostname, err := Casefold(client.hostname)
if err != nil {
client.server.logger.Error("internal", "nickmask couldn't be casefolded", nickMaskString, err.Error())
return
client.server.logger.Error("internal", "hostname couldn't be casefolded", client.hostname, err.Error())
cfhostname = client.hostname // YOLO
}
client.nickMaskString = nickMaskString
client.nickMaskCasefolded = nickMaskCasefolded
client.nickMaskString = fmt.Sprintf("%s!%s@%s", client.nick, client.username, client.hostname)
client.nickMaskCasefolded = fmt.Sprintf("%s!%s@%s", client.nickCasefolded, cfusername, cfhostname)
}
// AllNickmasks returns all the possible nickmasks for the client.