From 9374a75c7a820df5c5f42c47f37f65da42047ece Mon Sep 17 00:00:00 2001 From: Shivaram Lingamneni Date: Tue, 3 Nov 2020 20:59:03 -0500 Subject: [PATCH] implement FAIL CHATHISTORY INVALID_TARGET --- irc/handlers.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/irc/handlers.go b/irc/handlers.go index fd6581fb..ff69b241 100644 --- a/irc/handlers.go +++ b/irc/handlers.go @@ -556,9 +556,7 @@ func chathistoryHandler(server *Server, client *Client, msg ircmsg.IrcMessage, r } else if err == utils.ErrInvalidParams { rb.Add(nil, server.name, "FAIL", "CHATHISTORY", "INVALID_PARAMS", msg.Params[0], client.t("Invalid parameters")) } else if sequence == nil { - // send an empty batch as per the spec - batchID := rb.StartNestedHistoryBatch(utils.SafeErrorParam(target)) - rb.EndNestedBatch(batchID) + rb.Add(nil, server.name, "FAIL", "CHATHISTORY", "INVALID_TARGET", utils.SafeErrorParam(target), client.t("Messages could not be retrieved")) } else if err != nil { rb.Add(nil, server.name, "FAIL", "CHATHISTORY", "MESSAGE_ERROR", msg.Params[0], client.t("Messages could not be retrieved")) } else {