GitHub/ergo
3
0
Fork 0
mirror of https://github.com/ergochat/ergo.git synced 2024-11-26 05:49:25 +01:00
Code Issues Projects Releases Wiki Activity

explain why CheckPassword happens in client thread

Browse Source
This commit is contained in:
Jeremy Latt 2014-03-15 15:12:29 -07:00
parent b359d8c097
commit 7a9f1d750b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
irc/client.go
View File

@ -67,6 +67,11 @@ func (client *Client) run() {
checkPass, ok := command.(checkPasswordCommand) checkPass, ok := command.(checkPasswordCommand)
if ok { if ok {
checkPass.LoadPassword(client.server) checkPass.LoadPassword(client.server)
// Block the client thread while handling a potentially expensive
// password bcrypt operation. Since the server is single-threaded
// for commands, we don't want the server to perform the bcrypt,
// blocking anyone else from sending commands until it
// completes. This could be a form of DoS if handled naively.
checkPass.CheckPassword() checkPass.CheckPassword()
} }