From 6265b70622847c1f321f1b3339fea64dbb99a49e Mon Sep 17 00:00:00 2001
From: Jeremy Latt <jeremy.latt@gmail.com>
Date: Wed, 19 Feb 2014 18:13:35 -0800
Subject: [PATCH] get rid of goroutines on client socket

---
 irc/client.go |  6 +++-
 irc/socket.go | 99 +++++++++++++++++----------------------------------
 2 files changed, 38 insertions(+), 67 deletions(-)

diff --git a/irc/client.go b/irc/client.go
index f47c9834..f0658464 100644
--- a/irc/client.go
+++ b/irc/client.go
@@ -59,7 +59,11 @@ func NewClient(server *Server, conn net.Conn) *Client {
 //
 
 func (client *Client) readCommands() {
-	for line := range client.socket.Read() {
+	for {
+		line, err := client.socket.Read()
+		if err != nil {
+			break
+		}
 		msg, err := ParseCommand(line)
 		if err != nil {
 			switch err {
diff --git a/irc/socket.go b/irc/socket.go
index 567c6be3..71cb81bb 100644
--- a/irc/socket.go
+++ b/irc/socket.go
@@ -13,27 +13,19 @@ const (
 )
 
 type Socket struct {
-	conn    net.Conn
-	done    chan bool
-	reader  *bufio.Reader
-	receive chan string
-	send    chan string
-	writer  *bufio.Writer
+	closed bool
+	conn   net.Conn
+	reader *bufio.Reader
+	writer *bufio.Writer
 }
 
 func NewSocket(conn net.Conn) *Socket {
 	socket := &Socket{
-		conn:    conn,
-		done:    make(chan bool, 1),
-		reader:  bufio.NewReader(conn),
-		receive: make(chan string, 16),
-		send:    make(chan string, 16),
-		writer:  bufio.NewWriter(conn),
+		conn:   conn,
+		reader: bufio.NewReader(conn),
+		writer: bufio.NewWriter(conn),
 	}
 
-	go socket.readLines()
-	go socket.writeLines()
-
 	return socket
 }
 
@@ -42,23 +34,19 @@ func (socket *Socket) String() string {
 }
 
 func (socket *Socket) Close() {
-	socket.done <- true
-}
-
-func (socket *Socket) Read() <-chan string {
-	return socket.receive
-}
-
-func (socket *Socket) Write(lines ...string) {
-	for _, line := range lines {
-		socket.send <- line
+	if socket.closed {
+		return
+	}
+	socket.closed = true
+	socket.conn.Close()
+	if DEBUG_NET {
+		log.Printf("%s closed", socket)
 	}
-	return
 }
 
-func (socket *Socket) readLines() {
-	for {
-		line, err := socket.reader.ReadString('\n')
+func (socket *Socket) Read() (line string, err error) {
+	for len(line) == 0 {
+		line, err = socket.reader.ReadString('\n')
 		if socket.isError(err, R) {
 			break
 		}
@@ -70,53 +58,32 @@ func (socket *Socket) readLines() {
 		if DEBUG_NET {
 			log.Printf("%s → %s", socket, line)
 		}
-
-		socket.receive <- line
 	}
-
-	close(socket.receive)
-	socket.Close()
+	return
 }
 
-func (socket *Socket) writeLines() {
-	done := false
-	for !done {
-		select {
-		case line := <-socket.send:
-			if _, err := socket.writer.WriteString(line); socket.isError(err, W) {
-				break
-			}
-
-			if err := socket.writer.Flush(); socket.isError(err, W) {
-				break
-			}
-			if DEBUG_NET {
-				log.Printf("%s ← %s", socket, line)
-			}
-
-		case done = <-socket.done:
-			if DEBUG_NET {
-				log.Printf("%s done", socket)
-			}
-			continue
+func (socket *Socket) Write(lines ...string) (err error) {
+	for _, line := range lines {
+		err = socket.WriteLine(line)
+		if err != nil {
+			break
 		}
 	}
+	return
+}
 
-	if done {
-		socket.conn.Close()
+func (socket *Socket) WriteLine(line string) (err error) {
+	if _, err = socket.writer.WriteString(line); socket.isError(err, W) {
+		return
 	}
 
+	if err = socket.writer.Flush(); socket.isError(err, W) {
+		return
+	}
 	if DEBUG_NET {
-		log.Printf("%s closed", socket)
-	}
-
-	// read incoming messages and discard to avoid hangs
-	for {
-		select {
-		case <-socket.send:
-		case <-socket.done:
-		}
+		log.Printf("%s ← %s", socket, line)
 	}
+	return
 }
 
 func (socket *Socket) isError(err error, dir rune) bool {