GitHub/ergo
3
0
Fork 0
mirror of https://github.com/ergochat/ergo.git synced 2024-11-25 21:39:25 +01:00
Code Issues Projects Releases Wiki Activity

irc: fix timer memleak

Browse Source 
This is a gotcha called out in the `time.After` docs. `time.After` will
leak the underlying channel if nothing ever receives on it.
This commit is contained in:
Euan Kemp 2017-07-13 23:45:17 -07:00 committed by Daniel Oaks
parent b003cd6287
commit 2e8a98a925
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
irc/socket.go
View File

@ -133,10 +133,12 @@ func (socket *Socket) Write(data string) error {
// timedFillLineToSendExists either sends the note or times out. // timedFillLineToSendExists either sends the note or times out.
func (socket *Socket) timedFillLineToSendExists(duration time.Duration) { func (socket *Socket) timedFillLineToSendExists(duration time.Duration) {
lineToSendTimeout := time.NewTimer(duration)
defer lineToSendTimeout.Stop()
select { select {
case socket.lineToSendExists <- true: case socket.lineToSendExists <- true:
// passed data successfully // passed data successfully
case <-time.After(duration): case <-lineToSendTimeout.C:
// timed out send // timed out send
} }
} }