From 2cb91bab0464000e83014c0067284556e8c5873a Mon Sep 17 00:00:00 2001 From: Alex Jaspersen Date: Sat, 30 May 2020 15:45:43 +0000 Subject: [PATCH] Fix issue with one-character args in ArgsToStrings. --- irc/utils/args.go | 2 +- irc/utils/args_test.go | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/irc/utils/args.go b/irc/utils/args.go index 64475da1..ea3f0c96 100644 --- a/irc/utils/args.go +++ b/irc/utils/args.go @@ -35,7 +35,7 @@ func ArgsToStrings(maxLength int, arguments []string, delim string) []string { continue } - if len(buffer) > 1 { + if len(buffer) > 0 { buffer += delim } buffer += arguments[0] diff --git a/irc/utils/args_test.go b/irc/utils/args_test.go index 5c84b26a..b846d122 100644 --- a/irc/utils/args_test.go +++ b/irc/utils/args_test.go @@ -5,6 +5,14 @@ package utils import "testing" +func TestArgsToStrings(t *testing.T) { + val := ArgsToStrings(512, []string{"a", "b", "c"}, ",") + assertEqual(val, []string{"a,b,c"}, t) + + val = ArgsToStrings(10, []string{"abcd", "efgh", "ijkl"}, ",") + assertEqual(val, []string{"abcd,efgh", "ijkl"}, t) +} + func TestStringToBool(t *testing.T) { val, err := StringToBool("on") assertEqual(val, true, t)