review fixes

This commit is contained in:
Shivaram Lingamneni 2019-05-11 21:48:36 -04:00
parent 278e4acf57
commit 15289bd7db
3 changed files with 5 additions and 5 deletions

View File

@ -163,7 +163,7 @@ CAPDEFS = [
identifier="EventPlayback", identifier="EventPlayback",
name="draft/event-playback", name="draft/event-playback",
url="https://github.com/ircv3/ircv3-specifications/pull/362", url="https://github.com/ircv3/ircv3-specifications/pull/362",
standard="Draft IRCv3", standard="Proposed IRCv3",
), ),
] ]

View File

@ -109,7 +109,7 @@ const (
// https://wiki.znc.in/Query_buffers // https://wiki.znc.in/Query_buffers
ZNCSelfMessage Capability = iota ZNCSelfMessage Capability = iota
// EventPlayback is the Draft IRCv3 capability named "draft/event-playback": // EventPlayback is the Proposed IRCv3 capability named "draft/event-playback":
// https://github.com/ircv3/ircv3-specifications/pull/362 // https://github.com/ircv3/ircv3-specifications/pull/362
EventPlayback Capability = iota EventPlayback Capability = iota
) )

View File

@ -25,8 +25,8 @@ const (
Nick Nick
) )
// a Tagmsg that consists entirely of junk tags is not stored // a Tagmsg that consists entirely of transient tags is not stored
var junkTags = map[string]bool{ var transientTags = map[string]bool{
"+draft/typing": true, "+draft/typing": true,
"+typing": true, // future-proofing "+typing": true, // future-proofing
} }
@ -60,7 +60,7 @@ func (item *Item) HasMsgid(msgid string) bool {
func (item *Item) isStorable() bool { func (item *Item) isStorable() bool {
if item.Type == Tagmsg { if item.Type == Tagmsg {
for name := range item.Tags { for name := range item.Tags {
if !junkTags[name] { if !transientTags[name] {
return true return true
} }
} }