GitHub/ergo
3
0
Fork 0
mirror of https://github.com/ergochat/ergo.git synced 2026-03-15 19:58:01 +01:00
Code Issues Projects Releases Wiki Activity

allow testing irc/ with i18n compiled out (#2363)

Browse Source 
Add to `make test` as well
This commit is contained in:
Shivaram Lingamneni 2026-03-15 00:47:33 -07:00 committed by GitHub
parent 93495e2cf5
commit 0e76470249
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Makefile
View File

@ -41,6 +41,7 @@ test:
python3 ./gencapdefs.py | diff - ${capdef_file}
go test -tags "$(full_tags)" ./...
go vet -tags "$(full_tags)" ./...
go test ./...
go vet -tags "" ./...
./.check-gofmt.sh

17
irc/strings_test.go
View File

@ -11,6 +11,10 @@ import (
"github.com/ergochat/ergo/irc/i18n"
)
var (
asciiCasemappingOnly = []i18n.Casemapping{i18n.CasemappingASCII}
)
func TestCasefoldChannelAllCasemappings(t *testing.T) {
oldGlobalCasemapping := globalCasemappingSetting
t.Cleanup(func() {
@ -82,6 +86,9 @@ func TestCasefoldChannelAllCasemappings(t *testing.T) {
// don't test permissive because it doesn't fail on bidi violations
casemappings := []i18n.Casemapping{i18n.CasemappingASCII, i18n.CasemappingPRECIS}
if !i18n.Enabled {
casemappings = asciiCasemappingOnly // XXX allow testing this package with i18n compiled out
}
for _, casemapping := range casemappings {
globalCasemappingSetting = casemapping
@ -137,6 +144,9 @@ func TestCasefoldNameAllCasemappings(t *testing.T) {
}
casemappings := []i18n.Casemapping{i18n.CasemappingASCII, i18n.CasemappingPRECIS, i18n.CasemappingPermissive, i18n.CasemappingRFC1459Strict}
if !i18n.Enabled {
casemappings = asciiCasemappingOnly // XXX allow testing this package with i18n compiled out
}
for _, casemapping := range casemappings {
globalCasemappingSetting = casemapping
@ -189,10 +199,8 @@ func TestCanonicalizeMaskWildcard(t *testing.T) {
tester("shivaram", "shivaram!*@*", nil)
tester("slingamn!shivaram", "slingamn!shivaram@*", nil)
tester("ברוך", "ברוך!*@*", nil)
tester("hacker@monad.io", "*!hacker@monad.io", nil)
tester("Evan!hacker@monad.io", "evan!hacker@monad.io", nil)
tester("РОТАТО!Potato", "ротато!potato@*", nil)
tester("tkadich*", "tkadich*!*@*", nil)
tester("SLINGAMN!*@*", "slingamn!*@*", nil)
tester("slingamn!shivaram*", "slingamn!shivaram*@*", nil)
@ -206,4 +214,9 @@ func TestCanonicalizeMaskWildcard(t *testing.T) {
tester(":shivaram", "", errInvalidCharacter)
tester("shivaram!us er@host", "", errInvalidCharacter)
tester("shivaram!user@ho st", "", errInvalidCharacter)
if i18n.Enabled {
tester("ברוך", "ברוך!*@*", nil)
tester("РОТАТО!Potato", "ротато!potato@*", nil)
}
}