James Lu
ca93d1ad70
IRCParser: show an error when using "command --help" instead of silently outputting help text in the console
2017-03-06 16:30:43 -08:00
James Lu
76d74ab9bb
SECURITY: prevent DoS when calling --help on commands using IRCParser
...
argparse's default behaviour is to exit after displaying --help and --version information. However, doing so freezes the current IRC listener and essentially allows for DoS via IRC...
This bug does not affect any released (stable) version of PyLInk - only commits after 93c9b6289c
2017-03-06 16:11:04 -08:00
James Lu
2d03ceebc8
Merge branch 'wip/attr-deprecations' into devel
...
Closes #273 .
2017-03-05 00:15:03 -08:00
James Lu
9a9e0b2c20
Irc: deprecate the botdata field as well ( #273 )
2017-03-05 00:14:43 -08:00
James Lu
e8bf1d08bc
handlers, fantasy: migrate away from irc.botdata ( #273 )
2017-03-05 00:10:33 -08:00
James Lu
d318fbac77
protocols: migrate away from irc.botdata ( #273 )
2017-03-05 00:09:01 -08:00
James Lu
b4f70bdece
Irc: remove duplicate botdata assignment
2017-03-05 00:06:49 -08:00
James Lu
4284853a4a
Irc: remove internal use of 'conf' and 'botdata' ( #273 )
2017-03-05 00:06:44 -08:00
James Lu
7f070448b7
utils, Irc: add abstraction to warn on deprecated attribute usage ( #273 )
2017-03-05 00:00:26 -08:00
James Lu
47f0b7626f
clientbot: time out CAP/SASL after 5 seconds
...
Closes #424 .
2017-03-04 23:54:16 -08:00
James Lu
733d7d7c87
exec: add ieval command using the isolated local scope
2017-03-04 22:05:03 -08:00
James Lu
42ba1775d7
exec: add irc, source, and args to isolated locals scopes
...
This allows basic things like irc.reply() to work in 'iexec'.
2017-03-04 21:59:42 -08:00
James Lu
9420f21680
clientbot: send CAP LS before NICK/USER so that it consistently gets a response before connect
...
Previously, SASL was failing on networks like freenode, as the connection completed before a CAP response was received.
2017-03-03 15:39:28 -08:00
James Lu
3281e1e8c2
pylink-contribdl: normalize exit codes
2017-02-27 07:28:37 -08:00
James Lu
8a773dea4e
core: normalize exit codes
2017-02-27 07:26:29 -08:00
James Lu
7a1a4d9161
example-conf: document service-specific autojoin channels (from #423 )
2017-02-26 18:16:15 -08:00
James Lu
21c0c617c1
Merge branch 'server-service-channels' of https://github.com/IotaSpencer/PyLink into devel
...
Closes #423 .
2017-02-26 18:12:34 -08:00
James Lu
ae56ed6a32
services_support: fix service-specific key name
2017-02-26 18:11:20 -08:00
Ken Spencer
b3ec8a6790
service_support: allow server:service_channels for per service autojoin
2017-02-26 21:05:33 -05:00
James Lu
5fe277f90d
Irc: mention CIDR matching ( #411 ) and casemappings in matchHost() desc.
2017-02-25 22:26:37 -08:00
James Lu
4df8567fa6
Irc: move PYLINK_DISCONNECT firing and connected.clear() into disconnect() ( #421 )
...
This may prevent extra irc.connected.clear() calls from messing with the was_connected state.
2017-02-25 22:06:43 -08:00
James Lu
6fcb129ad6
hooks-reference: document the 'was_successful' key in PYLINK_DISCONNECT
2017-02-24 22:27:51 -08:00
James Lu
7c0cb92696
Irc: hack in CIDR support in matchHost() ( #411 )
2017-02-24 22:27:26 -08:00
James Lu
04fa0520a6
Irc: make was_successful check the last Irc.connected state
2017-02-24 22:09:41 -08:00
James Lu
cd65da75c6
relay: only announce disconnects if the last connection was successful
2017-02-24 21:42:58 -08:00
James Lu
b30d696e3a
Irc: add "was_successful" data key to PYLINK_DISCONNECT
...
This stores whether the network was actually connected before this disconnect message fired (i.e. the disconnect wasn't caused by a configuration error, etc.)
2017-02-24 21:42:44 -08:00
James Lu
cd3d795296
relay: implement optional network disconnect announcements
...
Closes #421 .
2017-02-24 21:15:40 -08:00
James Lu
0ebb52e64f
conf: simplify newlogins checks & allow missing permissions blocks if an old login is also present
2017-02-24 21:07:28 -08:00
James Lu
c03f2d772c
relay: allow dropping messages from user-less clients
...
This adds two new options, both defaulting to True:
- relay:accept_weird_senders (global)
- servers:<name>:relay_weird_senders (per-server)
Closes #404 .
2017-02-24 19:16:01 -08:00
James Lu
3d9f69dba7
Irc: deprecate checkAuthenticated()
2017-02-24 18:42:58 -08:00
James Lu
50ff330734
Merge branch 'master' into devel
2017-02-24 18:31:45 -08:00
James Lu
e07974f803
utils: remove reference to checkAuthenticated() in NotAuthorizedError
2017-02-24 18:31:33 -08:00
James Lu
a7280d2943
docs/t: more notes regarding the permissions API
2017-02-24 18:31:26 -08:00
James Lu
027c35b75a
PyLink 1.1.1
2017-02-24 17:56:43 -08:00
James Lu
6dd08e7dcb
corecommands: remove extraneous irc.checkAuthenticated() call
...
(cherry picked from commit fe3fa2872d
2017-02-24 17:50:20 -08:00
James Lu
fe3fa2872d
corecommands: remove extraneous irc.checkAuthenticated() call
2017-02-24 17:49:54 -08:00
James Lu
21cbcb8cf6
Irc: fix / simplify defaults in msg(), reply, error()
2017-02-24 16:28:23 -08:00
James Lu
46b18512cf
relay: less ambiguous error if a relay channel doesn't exist on the caller network
...
(cherry picked from commit 0b0efbaf9f
2017-02-22 15:42:52 -08:00
James Lu
f432f6f082
relay: don't allow linking to channels when the home network is down
...
This check can be overridden via --force, and should stop unreliable TS checks from appearing instead
Closes #419 .
2017-02-21 21:58:32 -08:00
James Lu
93c9b6289c
relay: switch to IRCParser in 'link' and add a --force option to skip TS checks
...
Closes #416 .
2017-02-21 21:52:22 -08:00
James Lu
bf702575be
servprotect: fix a syntax error
2017-02-21 21:49:41 -08:00
James Lu
0125c544ee
utils: add an IRCParser class based off argparse, modified from @IotaSpencer's code
...
Closes #6 .
2017-02-21 21:45:43 -08:00
James Lu
02faa3fcb6
relay: more verbosity in TS-related link errors
2017-02-21 21:14:03 -08:00
James Lu
84d62fc540
example-conf: update comment to match the last commit
2017-02-21 21:06:55 -08:00
Ken Spencer
b92ee03525
servprotect: match key (example-conf.yml) to grabbed key (servprotect.py) ( #418 )
2017-02-21 18:14:48 -08:00
James Lu
2e92f65782
example-conf: mention that servprotect::max_age needs a plugin reload to update
2017-02-21 17:07:32 -08:00
James Lu
0706b6cf78
Style/spacing fixes for last commit
2017-02-21 17:04:59 -08:00
Ken Spencer
a8fe353ba4
servprotect: make length and age configurable ( #417 )
...
Fixes #395
2017-02-21 17:02:26 -08:00
Ken Spencer
b3075d3414
conf: change asserts to validations ( #414 )
2017-02-21 10:10:54 -08:00
James Lu
f83a81242a
conf: reuse already-fetched newlogins value
2017-02-20 19:31:31 -08:00
