James Lu
9056799633
clientbot: only split /names replies by spaces
...
This fixes issues with colored hostnames because \x1f is treated as a whitespace char by str.split().
Closes #641 .
2019-04-08 22:35:37 -07:00
James Lu
1780271dd0
unreal: work around a potential race when sending kills on join
2019-03-01 23:34:41 -08:00
James Lu
ba17821af4
Declare visible-state-only by default in ClientbotBaseProtocol
2019-02-16 16:43:05 -08:00
James Lu
ac8b7babf1
inspircd: don't allow _ in hosts
...
CHGHOST on InspIRCd 2.0 does not see this as valid.
2019-02-12 15:55:10 -08:00
James Lu
cfbadb4539
Move _squit, _get_SID, _get_UID wrappers into PyLinkNCWUtils
...
ClientbotBaseProtocol requires these for the squit wrapper to work.
2019-02-12 00:38:37 -08:00
James Lu
873283e61e
clientbot: properly bounce kicks on networks not implementing them
2019-02-10 13:01:31 -08:00
James Lu
d089b8d40e
clientbot: split wrapper stuff into a ClientbotBaseProtocol class
...
Closes #632 .
2019-02-10 12:40:02 -08:00
James Lu
52f588c920
Track affected servers in SQUIT hooks
2018-12-27 12:09:40 -08:00
James Lu
4d39ad1c84
unreal: bump protocol version to 4200
...
Corresponding to UnrealIRCd 4.2.0.
2018-10-05 23:57:20 -07:00
James Lu
2f4476eb0c
unreal: remove invalid comparison
...
(Regression from commit fac6fe506f
)
2018-09-21 21:40:56 -07:00
James Lu
667fa610ec
unreal: remove duplicate conversion
2018-09-16 11:29:25 -07:00
James Lu
e929fda293
unreal: Bump protocol version to 4019 (4.0.19-rc1)
2018-09-12 17:35:30 -07:00
James Lu
d5fd7b03f5
unreal: enable slash-in-hosts, it seems to work fine
2018-09-12 17:35:25 -07:00
James Lu
fac6fe506f
unreal: use SJOIN in join() to work around weird TS corrupting bugs
...
This seems to be what Unreal itself does anyways.
2018-08-25 18:50:51 -04:00
James Lu
298913200c
clientbot: properly handle cases when the bot is told to kick itself
...
- Treat kicks to the PyLink client as a real user kick instead of a virtual one
- Forward on kick hooks if the PyLink client is kick target - this allows things like autorejoin to work
Closes #377 .
2018-08-25 01:14:26 -04:00
James Lu
5838d88404
networks: reload shared modules used by protocol modules too
2018-08-23 02:57:03 -04:00
James Lu
9cf507183d
clientbot: filter PART hooks for only parts we didn't initialize
...
This fixes Relay being confused by its own "Relay plugin unloaded" /part's, and makes Clientbot's behaviour in this regard consistent with other protocols.
2018-07-18 19:14:47 -07:00
James Lu
bba235bba2
Update GitHub repository address
2018-07-08 12:54:10 -07:00
James Lu
76c0db15c4
core: merge TLS validation code into IRCNetwork ( #592 )
...
Certificate verification is now enabled for all Clientbot networks, but not yet for S2S links (self-signed certs are common here and direct IP links even more so)
2018-06-15 15:29:15 -07:00
James Lu
4524aebbac
clientbot: initial pass of TLS cert validation ( #592 )
...
This works OK, but we should make the validation options built-in instead of clientbot-specific.
2018-06-15 02:47:12 -07:00
James Lu
040b009fcb
clientbot: ignore RPL_ENDOFBANLIST (368) responses for removed channels
2018-06-15 02:19:56 -07:00
James Lu
1b68bfadc6
coremods, plugins, protocols: drop now redundant allowAuthed=False in is_oper() calls
2018-06-11 23:56:44 -07:00
James Lu
1a97a32ef5
ircs2s_common: return just the kill reason as text in kill parsing ( #520 )
2018-06-11 19:26:42 -07:00
James Lu
31a0d36990
clientbot: ignore missing args in 324 / RPL_CHANNELMODEIS
...
Fixes #537 .
2018-06-08 18:45:20 -07:00
James Lu
1ab5d614c0
protocols: convert user TS to an int when receiving new users ( #594 )
2018-05-26 16:26:14 -07:00
James Lu
f20fa5e995
Add User.get_fields(), and rework plugins to fix $nick broken expansions
...
User.nick is no longer a writable attribute since a085aed924
, so it won't show up in __dict__ now.
get_fields() replaces the User.__dict__ hack various plugins used and also provides some new expansion variables:
- $sid and $server expand to the server ID and name respectively
- $modes and $channels are now preformatted strings
- $netname expands to the network name
$manipulatable and $_irc were removed since their values aren't quite meaningful as strings
2018-05-26 02:12:38 -07:00
James Lu
b9f782868c
inspircd: remove users from the state immediately when sending a kill
...
This matches Anope and Atheme's behaviours.
Closes #607 .
2018-05-21 00:33:13 -07:00
James Lu
3120fa5396
clientbot: stop sending duplicate JOIN hooks
...
Also set _clientbot_initial_who_received on 315/ENDOFWHO, instead of on the first /who response we get.
Really fixes #551 .
2018-05-09 22:31:19 -07:00
James Lu
451db74f0c
clientbot: don't send duplicate away statuses
2018-05-09 22:23:14 -07:00
James Lu
f54382534c
kick and kill should raise NotImplementedError when not supported by a protocol
...
Closes #605 .
2018-05-09 22:19:03 -07:00
James Lu
8eba402a33
clientbot: drop pre-WHO join bursting with userhost-in-names, it's too unreliable
...
Closes #602 .
Closes #551 .
2018-04-24 12:39:29 -07:00
James Lu
c7159b9cad
core: move clearing channels on kick/part to coremods/handlers
...
This is for consistency with the rest of the state cleanup code.
2018-04-07 22:44:00 -07:00
James Lu
9e212fc0a4
protocols: migrate utils.wrapArguments, splitHostmask use to camel case ( #523 )
2018-03-02 20:23:47 -08:00
James Lu
a2783d74c5
unreal: bump protocol version to 4017 (no changes needed)
2018-03-02 20:23:47 -08:00
James Lu
804791b8af
clientbot: support expansions ($nick, etc) in autoperform
2018-02-20 23:19:32 -08:00
James Lu
9cdb224c02
Replace use of conf.conf['bot'] with conf.conf['pylink']
2018-02-18 23:26:39 -08:00
James Lu
37be73d39c
clientbot: add STATUSMSG support ( #570 )
2018-02-18 22:15:19 -08:00
James Lu
ea84497359
protocols: remove the endburst_delay option from spawn_server
...
Interestingly, this was never documented in the protocol module spec...
2018-02-10 15:44:09 -08:00
James Lu
a425f873b5
relay, inspircd: move endburst delay code to a private API
...
This is a very specific hack that shouldn't be extended across the protocol module spec. So far, all other protocol modules ignore the endburst_delay option anyways.
2018-02-10 15:34:07 -08:00
James Lu
18c1a277f5
clientbot: remove extraneous use of to_lower() in handle_part
2018-01-31 19:35:24 -08:00
James Lu
74848853ac
clientbot: fix KeyError caused by lower() in spawn_server
...
This affected connections to afternet for example.
2018-01-31 19:33:05 -08:00
James Lu
84f6190478
inspircd: only read METADATA modules changes from the uplink
...
Closes #567 .
2018-01-25 09:52:29 -08:00
James Lu
6bb2198710
inspircd: move _modsupport.clear() to a _post_disconnect override
...
Speculative fix for #567 .
This may be caused by a race condition between post_connect and handle_capab, since the remote server can send its server data before we start sending ours.
2018-01-21 13:27:59 -08:00
James Lu
043a147b41
p10: fix hashed cloaks check reading from the wrong config variable
2017-12-31 12:09:36 -08:00
James Lu
56fa626605
inspircd: use clear() instead of replacing the _modsupport set
...
Maybe this will fix issues with _modsupport not being completely filled?
2017-12-27 11:48:00 -08:00
James Lu
7c0d279f61
inspircd: raise NotImplementedError instead of only warning when a CHG* module is missing
2017-12-22 12:41:48 -08:00
James Lu
92427201f1
inspircd: track module (un)loading
...
Closes #555 .
2017-12-22 12:38:48 -08:00
James Lu
958bb351ca
clientbot: log warnings if the bot cannot join a channel
...
Closes #533 .
This adds handlers for the following numerics:
* ERR_TOOMANYCHANNELS (405)
* ERR_CHANNELISFULL (471)
* ERR_INVITEONLYCHAN (473)
* ERR_BANNEDFROMCHAN (474)
* ERR_BADCHANNELKEY (475)
* ERR_BADCHANMASK (476)
* ERR_NEEDREGGEDNICK (477)
* ERR_BADCHANNAME (479)
* ERR_SECUREONLYCHAN / ERR_SSLONLYCHAN (489)
* ERR_DELAYREJOIN (495)
* ERR_OPERONLY (520)
2017-12-22 12:28:27 -08:00
James Lu
145a4677f6
ircs2s_common: add handling for nick@servername messages
2017-12-21 02:57:10 -08:00
James Lu
8dbbe65a1c
ircs2s_common: remove useless statusmsg splitting code
...
We used to do this in order to lowercase the channel part of ~#channel messages correctly, but that is no longer needed as of 9702030bf5
.
2017-12-21 02:11:28 -08:00
James Lu
f64976b1ed
p10: implement outgoing knock() as a wrapper over NOTICE
2017-12-21 01:53:41 -08:00
James Lu
16b491fdab
ts6_common, p10: declare protocol cap has-statusmsg
2017-12-21 01:34:41 -08:00
James Lu
20e730ba2b
p10: add inbound handlers for WALLCHOPS/WALLHOPS/WALLVOICES
...
This essentially finishes off STATUSMSG support on P10.
2017-12-21 01:27:19 -08:00
James Lu
2cc1195ff9
p10: refactor message() to send @%+#channel messages correctly
2017-12-21 01:20:08 -08:00
James Lu
454539185e
Move knock handling to ts6_common
...
This adds support for (reasonless) KNOCK on TS6.
2017-12-21 00:04:55 -08:00
James Lu
2245af1dba
Revert "ts6: handle ChatIRCd ENCAP USERMODE"
...
This reverts commit 785fc8d2d2
.
This feature isn't actually used yet and is relatively non-standard. Aside from that, the biggest issue so far is that ENCAP USERMODE doesn't give servers a way to explicitly acknowledge or reject(ignore) the mode change, which can lead to desyncs.
2017-12-18 17:20:37 -08:00
James Lu
ec3b230eab
inspircd: move definitions for cmodes +J and +E to kicknorejoin_insp and repeat_insp
...
These use InspIRCd specific arguments which don't map cleanly to other IRCds. #559
2017-12-18 13:10:48 -08:00
James Lu
a0c57d0a5a
unreal: register ~T extbans as filter and filter_censor ( #557 )
...
This doesn't work in relay yet because of #560 (as well as a restriction where acting extbans must match n!u@h...)
2017-12-07 00:36:38 -08:00
James Lu
80ef2ca788
hybrid: remove slash-in-hosts as it is not supported
2017-12-03 18:56:43 -08:00
James Lu
509c2e52c4
clientbot: fix KeyError when there are still queued outgoing messages to a channel we just left
2017-11-05 01:17:59 -08:00
James Lu
b366aa8d61
Merge branch 'wip/ts6-updates' into devel
2017-10-27 06:50:37 -07:00
James Lu
544e078512
clientbot: treat 0 as an empty account name (for WHOX)
...
This fixes incorrect "X is logged in (on somenet) as 0" messages in WHOIS.
2017-10-25 16:01:10 -07:00
James Lu
c974ee9b44
hybrid: various cleanup
2017-10-22 01:19:38 -07:00
James Lu
c636e064e7
ts6: remove SAVE from required capabs
...
We don't actually send SAVE out to any IRCd, so we don't need to demand that it's supported.
Closes #545 .
2017-10-22 01:08:30 -07:00
James Lu
5e7469b56f
Remove protocols/ratbox, superseded by ts6
...
Closes #543 .
2017-10-22 01:06:55 -07:00
James Lu
975d835c92
ts6: add support for ratbox, send EUID only when supported ( #543 )
2017-10-22 01:00:12 -07:00
James Lu
1a24bc19af
ts6: rename self.caps to self._caps
2017-10-22 00:44:30 -07:00
James Lu
3d3300e542
ts6: merge in CHGHOST checks and umode definitions from protocols/ratbox
2017-10-22 00:41:15 -07:00
James Lu
c2dbb74f5a
ts6: clean up mode definitions and target_ircd code
2017-10-22 00:29:00 -07:00
James Lu
4935ef521e
unreal: fix wrong hook name for legacy user introduction
2017-10-15 01:55:53 -07:00
James Lu
e8958962dd
unreal: fix authentication-in-progress check in handle_server
2017-10-15 01:54:39 -07:00
James Lu
aa44bc15a3
classes: fix backwards sorting in Channel.sort_prefixes()
...
Also remove various workaround code added to address this.
2017-10-15 01:29:42 -07:00
James Lu
66c762b63f
Merge remote-tracking branch 'origin/clientbot-fixes' into devel
2017-10-10 20:53:12 -07:00
James Lu
25ec88c566
clientbot: don't send empty MODE hooks when enumerating empty ban lists
2017-10-07 21:51:38 -07:00
James Lu
eca40a3d7c
coremods/handlers: implement cleanup code for visible-state-only servers
...
Closes #536 .
Closes #517 .
2017-10-07 21:49:17 -07:00
James Lu
de5ab051aa
clientbot: rename cap. clear-channels-on-leave => visible-state-only ( #517 )
2017-10-07 21:48:48 -07:00
James Lu
740b399ec2
clientbot: block attempts from virtual clients to change to an existing nick ( #535 )
2017-10-07 20:50:09 -07:00
James Lu
d7766d54d5
clientbot: check for nick collisions with virtual clients on NICK
...
Closes #535 .
2017-10-07 20:07:26 -07:00
James Lu
84ff797b5f
clientbot: rewrite _get_UID nick collision handling to be less confusing
2017-10-07 20:03:25 -07:00
James Lu
e25f6fd470
ircs2s_common: expand PUIDs in squit()
...
This fixes SQUIT not working correctly on ngIRCd.
2017-09-23 23:15:29 -07:00
James Lu
f74b34e99b
ts6: fix wrong prefix char for +a on ChatIRCd
...
This fixes users with +a disappearing when bursted to ChatIRCd.
2017-09-23 22:43:27 -07:00
James Lu
ad32ce20da
protocols: send outgoing hop counts for servers and users
...
Closes #527 .
2017-09-23 22:36:31 -07:00
James Lu
76a0eb78e3
clientbot: fix possible TypeError in squit()
2017-09-23 21:54:42 -07:00
James Lu
a2a32ed32f
clientbot: wrap outgoing modes to prevent cutoff
2017-09-23 21:54:02 -07:00
James Lu
6e89dbed24
clientbot: implement ban list enumeration on JOIN
...
Closes #530 .
2017-09-23 21:26:13 -07:00
James Lu
42d62fe28a
p10: pass IPv6 IPs on to supported servers
...
Closes #254 .
2017-09-23 13:20:58 -07:00
James Lu
6dec4bd96f
p10: fix wrong hook name for user introduction
2017-09-17 13:59:42 -07:00
James Lu
b9a4010acc
Merge branch 'master' into devel
...
Conflicts:
plugins/relay.py
2017-09-05 21:22:16 -07:00
James Lu
93704d85bf
unreal: fix TypeError when a set is given for modes in mode()
2017-09-05 21:21:16 -07:00
James Lu
8420587318
clientbot: warn when an outgoing message is blocked
...
Closes #497 .
(backported from commit 5112fcd7d1
)
2017-09-05 18:53:33 -07:00
James Lu
5112fcd7d1
clientbot: warn when an outgoing message is blocked
...
Closes #497 .
2017-09-02 21:46:35 -07:00
James Lu
1f270c985f
hybrid: drop EX and IE from required capabilities
...
This fixes compatibility with hybrid trunk, commit ircd-hybrid/ircd-hybrid@981c61e36c
(cherry picked from commit 30dc4a2b27
)
Conflicts:
protocols/hybrid.py
2017-08-31 15:07:04 -07:00
James Lu
a03214514c
hybrid, ts6, ratbox: fix +p mode definitions properly
...
+p is noknock and rfc1459-style private on all 3 IRCds, though the latter bit is undocumented in /help cmodes (maybe it's assumed?)
+p is also "paranoia" on hybrid, which adds more restrictions to halfops and /invite
(cherry picked from commit c107f0062f
)
2017-08-31 15:06:25 -07:00
James Lu
dd5a0c4892
ts6: fallback realhost to host, not None
...
(cherry picked from commit dfa90378df
)
2017-08-31 14:57:28 -07:00
James Lu
74ae6fd7c0
p10: add support for nefarious2 extbans
...
Closes #524 .
2017-08-31 14:52:03 -07:00
James Lu
2d2b524a63
ngircd: disable slash-in-nicks
...
This breaks user mode changes, as it is one of the only commands to undergo nick validation when received from a remote server.
2017-08-31 14:09:04 -07:00
James Lu
ac89f45683
ngircd: rework NJOIN code
...
- Fix "Internal NJOIN error"s caused by joining users already in the channel again
- Fix NJOIN being sent from the wrong internal server
- Condense two iterations over the user list into one
2017-08-31 13:17:28 -07:00
James Lu
8170e777e8
protocols: move setting irc.connected to endburst
2017-08-30 19:39:57 -07:00
James Lu
9a84dbde71
protocols: consistently track ENDBURST on sub-servers too
2017-08-30 19:18:39 -07:00
James Lu
4a363aee50
Move _expandPUID into PyLinkNetworkCoreWithUtils
2017-08-30 00:56:18 -07:00