GitHub/PyLink
3
0
Fork 0
mirror of https://github.com/jlu5/PyLink.git synced 2024-11-27 13:09:23 +01:00
Code Issues Projects Releases Wiki Activity

clientbot: fix nick() using the wrong arguments

Browse Source 
I should learn to proofread...

Also, outgoing NICK changes should not implicitly update the state; we should wait for the IRCd's acknowledgement instead.
This commit is contained in:
James Lu 2016-08-24 22:54:53 -07:00
parent a04bf6119e
commit 814c714145
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
protocols/clientbot.py
View File

@ -180,10 +180,11 @@ class ClientbotWrapperProtocol(Protocol):
def nick(self, source, newnick): def nick(self, source, newnick):
"""STUB: Sends NICK changes.""" """STUB: Sends NICK changes."""
if source == self.irc.pseudoclient.uid: if source == self.irc.pseudoclient.uid:
self.irc.send('NICK :%s' % (channel, self._expandPUID(target), reason)) self.irc.send('NICK :%s' % newnick)
# No state update here: the IRCd will respond with a NICK acknowledgement if the change succeeds.
else: else:
self.irc.callHooks([source, 'CLIENTBOT_NICK', {'newnick': newnick}]) self.irc.callHooks([source, 'CLIENTBOT_NICK', {'newnick': newnick}])
self.irc.users[source].nick = newnick self.irc.users[source].nick = newnick
def notice(self, source, target, text): def notice(self, source, target, text):
"""Sends notices to the target.""" """Sends notices to the target."""