GitHub/PyLink
3
0
Fork 0
mirror of https://github.com/jlu5/PyLink.git synced 2024-11-30 14:49:28 +01:00
Code Issues Projects Releases Wiki Activity

Clientbot: unconditionally block MODE hooks if we're the sender

Browse Source 
This is another check to prevent possible infinite loops in MODE syncing.
This commit is contained in:
James Lu 2016-10-07 20:54:15 -07:00
parent 72ca41df33
commit 5c2e7e9324
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
protocols/clientbot.py
View File

@ -606,7 +606,11 @@ class ClientbotWrapperProtocol(Protocol):
log.debug('(%s) Suppressing MODE change hook for internal client %s', self.irc.name, target)
return
if changedmodes:
return {'target': target, 'modes': changedmodes, 'channeldata': oldobj}
# Prevent infinite loops: don't send MODE hooks if the sender is US.
# Note: this is not the only check in Clientbot to prevent mode loops: if our nick
# somehow gets desynced, this may not catch everything it's supposed to.
if (self.irc.pseudoclient and source != self.irc.pseudoclient.uid) or not self.irc.pseudoclient:
return {'target': target, 'modes': changedmodes, 'channeldata': oldobj}
def handle_nick(self, source, command, args):
"""Handles NICK changes."""