GitHub/PyLink
3
0
Fork 0
mirror of https://github.com/jlu5/PyLink.git synced 2025-01-24 11:14:07 +01:00
Code Issues Projects Releases Wiki Activity

inspircd: get rid of IDLE->WHOIS hack

Browse Source 
This is unnecessary as sending 0 for both the idle time and signon time will tell the IRCd to not show anything.

...But we track our startup time, so we can actually pass that as a value (Anope does this as well)
This commit is contained in:
James Lu 2017-07-12 07:23:00 -07:00
parent 1438f9e566
commit 3fb563bb43
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
protocols/inspircd.py
View File

@ -606,24 +606,15 @@ class InspIRCdProtocol(TS6BaseProtocol):
return {'target': channel, 'modes': changedmodes, 'ts': ts, return {'target': channel, 'modes': changedmodes, 'ts': ts,
'channeldata': oldobj} 'channeldata': oldobj}
def handle_idle(self, numeric, command, args): def handle_idle(self, source, command, args):
""" """
Handles the IDLE command, sent between servers in remote WHOIS queries. Handles the IDLE command, sent between servers in remote WHOIS queries.
""" """
# <- :70MAAAAAA IDLE 1MLAAAAIG # <- :70MAAAAAA IDLE 1MLAAAAIG
# -> :1MLAAAAIG IDLE 70MAAAAAA 1433036797 319 # -> :1MLAAAAIG IDLE 70MAAAAAA 1433036797 319
sourceuser = numeric
targetuser = args[0]
# HACK: make PyLink handle the entire WHOIS request. # First arg = source, second = signon time, third = idle time
# This works by silently ignoring the idle time request, and sending our WHOIS data as self._send_with_prefix(args[0], 'IDLE %s %s 0' % (source, self.start_ts))
# raw numerics instead.
# The rationale behind this is that PyLink cannot accurately track signon and idle times for
# things like relay users, without forwarding WHOIS requests between servers in a way the
# hooks system is really not optimized to do. However, no IDLE response means that no WHOIS
# data is ever sent back to the calling user, so this workaround is probably the best
# solution (aside from faking values). -GLolol
return {'target': args[0], 'parse_as': 'WHOIS'}
def handle_ftopic(self, numeric, command, args): def handle_ftopic(self, numeric, command, args):
"""Handles incoming FTOPIC (sets topic on burst).""" """Handles incoming FTOPIC (sets topic on burst)."""