Make default max nick length a config option

config.yml.example

@@ -51,6 +51,10 @@ servers:
         # Separator character (used by relay)
         separator: "/"
 
+        # Sets the max nick length for the network. It is important this is set correctly, or
+        # PyLink might introduce a nick that is too long and cause netsplits!
+        maxnicklen: 30
+
 # Plugins to load (omit the .py extension)
 plugins:
     - commands

main.py

@@ -36,13 +36,11 @@ class Irc():
                        'oper': 'o',
                        '*A': '', '*B': '', '*C': 's', '*D': 'iow'}
 
-        # This nicklen value is only a default, and SHOULD be set by the
+        # This max nick length starts off as the config value, but may be
-        # protocol module as soon as the relevant capability information is
+        # overwritten later by the protocol module if such information is
-        # received from the uplink. Plugins that depend on maxnicklen being
+        # received. Note that only some IRCds (InspIRCd) give us nick length
-        # set MUST call "irc.connected.wait()", which blocks until the
+        # during link, so it is still required that the config value be set!
-        # capability information is received. This handling of irc.connected
+        self.maxnicklen = self.serverdata['maxnicklen']
-        # is also dependent on the protocol module.
-        self.maxnicklen = 30
         self.prefixmodes = {'o': '@', 'v': '+'}
 
         # Uplink SID (filled in by protocol module)