GitHub/PyLink
3
0
Fork 0
mirror of https://github.com/jlu5/PyLink.git synced 2025-02-03 08:04:07 +01:00
Code Issues Projects Releases Wiki Activity

relay: replace garbage locking code with proper filtering in relay_joins

Browse Source 
I'm not even going to start on how much time I spent working on this...

Closes #548, #529
This commit is contained in:
James Lu 2017-11-12 11:56:33 -08:00
parent d4cbf1d2af
commit 03e02dda51
1 changed files with 50 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
plugins/relay.py
View File

@ -473,17 +473,11 @@ def initialize_channel(irc, channel):
# We're initializing a relay that already exists. This can be done at # We're initializing a relay that already exists. This can be done at
# ENDBURST, or on the LINK command. # ENDBURST, or on the LINK command.
relay = get_relay(irc, channel) relay = get_relay(irc, channel)
log.debug('(%s) relay.initialize_channel being called on %s', irc.name, channel) log.debug('(%s) relay.initialize_channel being called on %s', irc.name, channel)
log.debug('(%s) relay.initialize_channel: relay pair found to be %s', irc.name, relay) log.debug('(%s) relay.initialize_channel: relay pair found to be %s', irc.name, relay)
queued_users = [] queued_users = []
if relay: if relay:
# Only allow one thread to initialize channels at a time.
if relay in channels_init_in_progress and channels_init_in_progress[relay].is_set():
log.debug('(%s) relay.initialize_channel: skipping init of %s since another one is in progress', irc.name, relay)
return
channels_init_in_progress[relay].set()
try:
all_links = db[relay]['links'].copy() all_links = db[relay]['links'].copy()
all_links.update((relay,)) all_links.update((relay,))
log.debug('(%s) relay.initialize_channel: all_links: %s', irc.name, all_links) log.debug('(%s) relay.initialize_channel: all_links: %s', irc.name, all_links)
@ -500,13 +494,25 @@ def initialize_channel(irc, channel):
# from the config. Skip this. # from the config. Skip this.
continue continue
if not (remoteirc.connected.is_set() and get_remote_channel(remoteirc, irc, remotechan)): # Give each network a tiny bit of leeway to finish up its connection.
continue # Remote network isn't connected. # This is better than just dropping users their completely.
if not remoteirc.connected.wait(TCONDITION_TIMEOUT):
continue
# Join their (remote) users and set their modes, if applicable. # Join their (remote) users and set their modes, if applicable.
if remotechan in remoteirc.channels: if remotechan in remoteirc.channels:
rc = remoteirc.channels[remotechan] rc = remoteirc.channels[remotechan]
relay_joins(remoteirc, remotechan, rc.users, rc.ts) '''
if not hasattr(rc, '_relay_initial_burst'):
rc._relay_initial_burst = threading.Event()
if rc._relay_initial_burst.is_set():
log.debug('(%s) relay.initialize_channel: skipping inbound burst from %s/%s => %s/%s '
'as it has already been bursted', irc.name, remoteirc.name, remotechan, irc.name, channel)
continue
rc._relay_initial_burst.set()
'''
relay_joins(remoteirc, remotechan, rc.users, rc.ts, targetirc=irc)
# Only update the topic if it's different from what we already have, # Only update the topic if it's different from what we already have,
# and topic bursting is complete. # and topic bursting is complete.
@ -515,12 +521,11 @@ def initialize_channel(irc, channel):
# Send our users and channel modes to the other nets # Send our users and channel modes to the other nets
if channel in irc.channels: if channel in irc.channels:
relay_joins(irc, channel, irc.channels[channel].users, irc.channels[channel].ts) c = irc._channels[channel]
relay_joins(irc, channel, c.users, c.ts)
if 'pylink' in world.services: if 'pylink' in world.services:
world.services['pylink'].join(irc, channel) world.services['pylink'].join(irc, channel)
finally:
channels_init_in_progress[relay].clear()
def remove_channel(irc, channel): def remove_channel(irc, channel):
"""Destroys a relay channel by parting all of its users.""" """Destroys a relay channel by parting all of its users."""
@ -673,9 +678,10 @@ def iterate_all_present(origirc, origuser, func, extra_args=(), kwargs=None):
### EVENT HANDLER INTERNALS ### EVENT HANDLER INTERNALS
def relay_joins(irc, channel, users, ts, **kwargs): def relay_joins(irc, channel, users, ts, targetirc=None, **kwargs):
""" """
Relays one or more users' joins from a channel to its relay links. Relays one or more users' joins from a channel to its relay links. If targetirc is given, only burst
to that specific network.
""" """
if ts < 750000: if ts < 750000:
@ -740,6 +746,9 @@ def relay_joins(irc, channel, users, ts, **kwargs):
remoteirc.call_hooks([rsid, 'PYLINK_RELAY_JOIN', {'channel': remotechan, 'users': [u[-1] for u in queued_users]}]) remoteirc.call_hooks([rsid, 'PYLINK_RELAY_JOIN', {'channel': remotechan, 'users': [u[-1] for u in queued_users]}])
if targetirc:
_relay_joins_loop(irc, targetirc, channel, users, ts, **kwargs)
else:
iterate_all(irc, _relay_joins_loop, extra_args=(channel, users, ts), kwargs=kwargs) iterate_all(irc, _relay_joins_loop, extra_args=(channel, users, ts), kwargs=kwargs)
def relay_part(irc, *args, **kwargs): def relay_part(irc, *args, **kwargs):