GibCasa/GameServerSupervisor
3
0
Fork 1
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

Improves handling port mapping #29

Merged
pratyush merged 2 commits from fix/port_mapping into master 2025-04-23 06:49:43 +02:00
Conversation 1 Commits 2 Files Changed 8 +191 -21
pratyush commented 2025-04-23 00:16:02 +02:00
Owner
Copy Link

switched port field to a JSONField adds a helper function to display server port mapping in admin launching a container will map the ports appropriately Instead of typing json to map ports we have a widget replaced by such text fields. where one can + button to add or - to remove i.e. [container_port/proto]:[host_port] At first port was an IntegerField. Hence i added a manual migration which is the latest one to get them to be default:port(old value)

Signed-off-by: Pratyush Desai pratyush.desai@liberta.casa

switched port field to a JSONField adds a helper function to display server port mapping in admin launching a container will map the ports appropriately Instead of typing json to map ports we have a widget replaced by such text fields. where one can + button to add or - to remove i.e. [container_port/proto]:[host_port] At first port was an IntegerField. Hence i added a manual migration which is the latest one to get them to be default:port(old value) Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
pratyush added 1 commit 2025-04-23 00:16:03 +02:00 
switched port field to a JSONField
adds a helper function to display server port mapping in admin
launching a container will map the ports appropriately
Instead of typing json to map ports we have a widget
replaced by such text fields. where one can + button to add or
- to remove
i.e.
 [container_port/proto]:[host_port]
At first port was an IntegerField.
Hence i added a manual migration which is the latest one
to get them  to be default:port(old value)

Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
pratyush commented 2025-04-23 00:19:28 +02:00
Author
Owner
Copy Link

There has some dirty / repetitive code perhaps slipped into this. I’m gonna have to assimilate all such issues and solve them premerge. ramifications of things like the templae for the widget .

There has some dirty / repetitive code perhaps slipped into this. I'm gonna have to assimilate all such issues and solve them premerge. ramifications of things like the `templae` for the `widget` .
pratyush added 1 commit 2025-04-23 06:29:22 +02:00 
I think we need to check these snippets rather carefully
somepoint not too far

Signed-off-by: Pratyush Desai <pratyush.desai@liberta.casa>
pratyush merged commit c836caa6af into master 2025-04-23 06:49:43 +02:00
pratyush deleted branch fix/port_mapping 2025-04-23 06:49:44 +02:00
pratyush changed title from WIP : Improves handling port mapping to Improves handling port mapping 2025-04-24 08:56:29 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
calm-steam pratyush samsepi0l
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GibCasa/GameServerSupervisor#29
No description provided.
Delete Branch "fix/port_mapping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?