Georg/dbot
1
0
Fork 0
forked from GitHub/dbot
Code Issues Pull Requests Projects Releases Wiki Activity

Refactored ~kickstats so there's no code repitition.

Browse Source
This commit is contained in:
Luke Slater 2012-02-11 16:17:52 +00:00
parent e79854638a
commit c798e42152
1 changed files with 21 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
modules/user.js
View File

@ -1,12 +1,16 @@
// Commands that probably belong elsewhere.
var userCommands = function(dbot) { var userCommands = function(dbot) {
var dbot = dbot; var dbot = dbot;
var commands = { var commands = {
// Give a karma comment for a given user
'~kc': function(data, params) { '~kc': function(data, params) {
dbot.say('aisbot', '.karma ' + data.message.split(' ')[1]); dbot.say('aisbot', '.karma ' + data.message.split(' ')[1]);
dbot.waitingForKarma = data.channel; dbot.waitingForKarma = data.channel;
}, },
// Give the number of times a given user has been kicked and has kicked
// other people.
'~kickcount': function(data, params) { '~kickcount': function(data, params) {
if(!dbot.db.kicks.hasOwnProperty(params[1])) { if(!dbot.db.kicks.hasOwnProperty(params[1])) {
var kicks = '0'; var kicks = '0';
@ -20,47 +24,33 @@ var userCommands = function(dbot) {
var kicked = dbot.db.kickers[params[1]]; var kicked = dbot.db.kickers[params[1]];
} }
dbot.say(data.channel, params[1] + ' has been kicked ' + kicks + ' times and has kicked people ' + kicked + ' times.'); dbot.say(data.channel, params[1] + ' has been kicked ' + kicks + ' times and has kicked people ' + kicked + ' times.');
}, },
// Output a list of the people who have been kicked the most and those
// who have kicked other people the most.
'~kickstats': function(data, params) { '~kickstats': function(data, params) {
var orderedKickLeague = function(list, topWhat) {
var kickArr = []; var kickArr = [];
for(var kickUser in dbot.db.kicks) { for(var kickUser in list) {
if(dbot.db.kicks.hasOwnProperty(kickUser)) { if(list.hasOwnProperty(kickUser)) {
kickArr.push([kickUser, dbot.db.kicks[kickUser]]); kickArr.push([kickUser, list[kickUser]]);
} }
} }
var orderedKicks = kickArr.sort(function(a, b) { return a[1] - b[1]; }); kickArr = kickArr.sort(function(a, b) { return a[1] - b[1]; });
var topKicks = kickArr.slice(kickArr.length - 10).reverse(); kickArr = kickArr.slice(kickArr.length - 10).reverse();
var kickString = "Top Kicked: "; var kickString = "Top " + topWhat + ": ";
for(var i=0;i<topKicks.length;i++) { for(var i=0;i<topKicks.length;i++) {
kickString += topKicks[i][0] + " (" + topKicks[i][1] + "), "; kickString += topKicks[i][0] + " (" + topKicks[i][1] + "), ";
} }
kickString = kickString.slice(0, -2);
dbot.say(data.channel, kickString); return kickString.slice(0, -2);
};
// code repetition bad dbot.say(data.channel, orderedKickLeague(dbot.db.kicks, 'Kicked'));
var kickArr = []; dbot.say(data.channel, orderedKickLeague(dbot.db.kickers, 'Kickers'));
for(var kickUser in dbot.db.kickers) {
if(dbot.db.kickers.hasOwnProperty(kickUser)) {
kickArr.push([kickUser, dbot.db.kickers[kickUser]]);
}
}
var orderedKicks = kickArr.sort(function(a, b) { return a[1] - b[1]; });
var topKicks = kickArr.slice(kickArr.length - 10).reverse();
var kickString = "Top Kickers: ";
for(var i=0;i<topKicks.length;i++) {
kickString += topKicks[i][0] + " (" + topKicks[i][1] + "), ";
}
kickString = kickString.slice(0, -2);
dbot.say(data.channel, kickString);
} }
}; };