From 6c89e107d89374a94cb4c5d58f5285e4e895df39 Mon Sep 17 00:00:00 2001
From: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
Date: Thu, 29 Aug 2024 04:26:29 +0200
Subject: [PATCH] Spec file cleanup

- Run spec-cleaner
- Set prefix and correct installation directories
  (mandir needs share/ subdirectory for packaged installations,
  sysconfdir needs to be /etc as AppArmor does not support /usr/etc)
- Exclude unneeded AppArmor files if built without AppArmor support
- Add group to make rpmlint happy
- Build as noarch as binary is interpreted language

Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
---
 buddycheck.spec | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/buddycheck.spec b/buddycheck.spec
index ebcf665..d9ede8d 100644
--- a/buddycheck.spec
+++ b/buddycheck.spec
@@ -16,15 +16,17 @@
 # Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
-%bcond_without apparmor
 
+%bcond_without apparmor
 Name:           buddycheck
 Version:        1
 Release:        0
 Summary:        Health check
 License:        EUPL-1.2
+Group:          System/Monitoring
 URL:            https://git.com.de/Georg/buddycheck
 Source:         %{name}-%{version}.tar.zst
+BuildArch:      noarch
 %if %{with apparmor}
 BuildRequires:  apparmor-rpm-macros
 %endif
@@ -39,7 +41,7 @@ BuddyCheck is a tool querying the systemd health through Prometheus Node Exporte
 # Perl script, nothing to build
 
 %install
-%make_install
+%make_install PREFIX=%{_prefix} MANDIR=%{_mandir} SYSCONFDIR=%{_sysconfdir}
 
 %if %{with apparmor}
 %post
@@ -50,11 +52,13 @@ BuddyCheck is a tool querying the systemd health through Prometheus Node Exporte
 %license LICENSE
 %doc README.txt
 %{_bindir}/%{name}
-%{_mandir}/man1/%{name}.1%{ext_man}
-%if %{without apparmor}
-%exclude
+%{_mandir}/man1/%{name}.1%{?ext_man}
+%if %{with apparmor}
+%dir %{_sysconfdir}/apparmor.d
+%config %{_sysconfdir}/apparmor.d/%{name}
+%else
+%exclude %dir %{_sysconfdir}/apparmor.d
+%exclude %config %{_sysconfdir}/apparmor.d/%{name}
 %endif
-%{_sysconfdir}/apparmor.d/%{name}
 
 %changelog
-